-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move shiny::addResourcePath to .onLoad() #100
Comments
I converted my shiny app into an R package and I was SO confused about why my tips and popovers stopped working. And I really liked all my tips and popovers! Calling Chipping at it, I found that adding this line to my server function brought the functionality back: The .onLoad() solution sounds reasonable to me, but I don't know all of the consequences of using .onAttach() vs .onLoad(); so I can't say if that is the best solution. What I CAN say is: please count my experience as an up-vote of the fact that there is a real problem in the current setup. If for some reason you don't like the .onLoad() approach, something like a |
shinyBS resource publishing via
shiny::addResourcePath
is only performed.onAttach()
and not.onLoad()
shinyBS/R/misc.R
Lines 1 to 6 in c329f8c
This can cause problems for Shiny apps which do not load attach shinyBS but only load its namespace (e.g., apps shipped as part of packages, with strict control over dependencies).
See related issues #92 and yonicd/ggedit#17 and comments therein.
The text was updated successfully, but these errors were encountered: