-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let jobs retweak easyconfigs themselves #4669
base: 5.0.x
Are you sure you want to change the base?
Conversation
This can be accomplished by tweak() optionally also returning a dict which maps the tweaked easyconfig to the original version. Then the job can run `eb ... <original_easyconfig.eb> --try-*` and that original easyconfig will be retweaked in the job itself. If the easyconfig passed to the job is not tweaked, then `--try-*` is *not* passed down (so, with `--robot`, some jobs will have `--try-*` and some don't). This removes the requirement of a shared tmpdir with `--job --try-*`. Fixes easybuilders#1355
Putting to draft because this needs a proper test combining |
One dep needs --try-toolchain and the other doesn't in the resulting job.
@bartoldeman Seems like test was implemented, so this shouldn't be a draft PR anymore? |
Justed wanted to test locally using Note that a shared temporary directory is still needed with |
@boegel undrafted now |
This can be accomplished by
tweak()
optionally also returning a dict which maps the tweaked easyconfig to the original version. Then the job can runeb ... <original_easyconfig.eb> --try-*
and that original easyconfig will be retweaked in the job itself.If the easyconfig passed to the job is not tweaked, then
--try-*
is not passed down (so, with--robot
, some jobs will have--try-*
and some don't).This removes the requirement of a shared tmpdir with
--job --try-*
.Fixes #1355