Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix help message for --http-headers-fields-urlpat configuration option #4594

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Louwrensth
Copy link
Contributor

The --help message for --http-headers-fields-urlpat contained an error in the example.

Also try to make the help text read a little easier.

@boegel boegel added the bug fix label Aug 13, 2024
@boegel boegel added this to the release after 4.9.2 milestone Aug 13, 2024
@boegel
Copy link
Member

boegel commented Aug 13, 2024

@Louwrensth Any reason this is a draft PR?

@boegel boegel changed the title fix help message for option http-headers-fields-urlpat fix help message for --http-headers-fields-urlpat configuration option Aug 13, 2024
@Louwrensth
Copy link
Contributor Author

@Louwrensth Any reason this is a draft PR?

I want to talk about this actually. But technically : I think this one is good to go -- there is not more stuff coming.

The reason why I made it a draft was to not burden you guys with review requests too early. Sometimes we (some people at ITER) have several PRs, and they get attention at the start of the PR, there are usually some good suggestions to improve, but after doing those changes the back-and-forth seems to slow down and the PR seems ignored. Maybe the PR just goes down on the radar? I feel your team have a lot of reviews on your plate.

How can we organize it best for all of us?

I wanted to hold back a bunch of PRs until I can offer a bundle of them for you. Does that help at all?

@boegel
Copy link
Member

boegel commented Aug 27, 2024

@Louwrensth It would be better to discuss this in Slack or via email, since it's out of the context of this PR, but: I'm not sure there's an easy way to prevent that PRs get overlooked over time. We're doing what we can to keep up with contributions, but it's definitely a challenge.

Let's discuss this via another channel: maybe reach out via Slack, and we'll explore some options, we're happy to try and work out an approach that's feasible with the manpower we have available...

@boegel boegel merged commit 1a26053 into easybuilders:develop Aug 27, 2024
37 checks passed
@Louwrensth Louwrensth deleted the fix_help_msg_http_headers branch August 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants