clean up code that was only there to support Python 2.6 + avoid syntax warnings when parsing py2vs3/py.p2 with Python 3.x #3788
Conversation
Flamefire
force-pushed
the
python27
branch
2 times, most recently
from
3acb6a5
to
5730b97
Compare
Flamefire
force-pushed
the
python27
branch
2 times, most recently
from
4448ded
to
d97ca5c
Compare
| # GitHub also supports SVN | ||
| test_repo_url = 'https://[email protected]/kehoste/testrepository' | ||
|
|
||
| repo = HgRepository(test_repo_url) |
There was a problem hiding this comment.
Not testing this anymore means we should also deprecate the use of HgRepository, so we can drop support entirely in EasyBuild 5.0?
There was a problem hiding this comment.
We haven't tested this for ages, I just removed the dead code. No idea if you want to deprecate this as Mercury isn't exactly dead but I don't really care. If it works why not keep it. Might add a test later or deprecate it later.
PS: I love the comment above a mercury bitbucket URL about github and SVN ;)
boegel
changed the title
|
Apart from that I think this is good enough. @boegel do you want a deprecation warning for HgRepository? |
This is from the python installation since 2.7
Use recent version of keyrings Remove redundant stuff Reordering
|
--> #4607 for 5.0x |
|
@Flamefire With #4607 merged, I guess we can close this? |
|
Python 2.6. is not supported by EB AFAIK but the I'd still merge this but am fine with closing given the issues have been fixed in 5.x |
easybuild/tools/py2vs3/py3.py
Outdated
| @@ -37,7 +37,6 @@ | |||
| import subprocess | |||
| import sys | |||
| import urllib.request as std_urllib # noqa | |||
| from collections import OrderedDict # noqa | |||
There was a problem hiding this comment.
We can't/shouldn't make a breaking change like this in EasyBuild 4.x, it will break any from easybuild.tools.py2vs3 import OrderedDict out there...
There was a problem hiding this comment.
Makes sense. Reverted that change
boegel
changed the title
boegel
changed the title
As Python <2.7 support was dropped in EasyBuild 4.4 (see #3715) I cleaned up the code that supports 2.6 which means removal of
OrderedDictas well as some more unittest/CI codeAdditionally I fixed the known issue that installing EB in Python3 shows a syntax error warning.