Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for downloading easyconfigs from multiple PRs with --from-pr #3605

Merged
merged 7 commits into from
May 25, 2021
Merged

add support for downloading easyconfigs from multiple PRs with --from-pr #3605

merged 7 commits into from
May 25, 2021

Conversation

migueldiascosta
Copy link
Member

closes #1686

@migueldiascosta migueldiascosta added this to the next release (4.3.4?) milestone Mar 11, 2021
@easybuilders easybuilders deleted a comment from boegelbot Mar 12, 2021
@easybuilders easybuilders deleted a comment from boegelbot Mar 16, 2021
@akesandgren
Copy link
Contributor

@migueldiascosta Conflict resolution needed

@migueldiascosta migueldiascosta changed the title add support for multiple PRs in --from-pr (WIP) add support for multiple PRs in --from-pr May 25, 2021
akesandgren
akesandgren previously approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akesandgren
akesandgren requested changes May 25, 2021
View reviewed changes
easybuild/tools/filetools.py Outdated Show resolved Hide resolved
akesandgren
akesandgren approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel boegel merged commit e0bb957 into easybuilders:develop May 25, 2021
@boegel boegel mentioned this pull request May 27, 2021
Merged
@Flamefire Flamefire mentioned this pull request May 28, 2021
Merged
@boegel boegel changed the title add support for multiple PRs in --from-pr add support for downloading easyconfigs from multiple PRs with --from-pr Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Feature for the future: eb --from-pr 2524,2523 -Dr
3 participants
@migueldiascosta @akesandgren @boegel