Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse variable name in the loop to fix adding extra compiler flags via toolchainopts #3571

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 9, 2021

(created using eb --new-pr)

With: toolchainopts = {'opt': True, 'extra_cxxflags': '-ip'} we currently get:

F90FLAGS=-O3 -xHost -ftz -fp-speculation=safe -fp-model source -- -i -p
CXXFLAGS=-O3 -xHost -ftz -fp-speculation=safe -fp-model source -ip
FCFLAGS=-O3 -xHost -ftz -fp-speculation=safe -fp-model source -- -i -p
FFLAGS=-O3 -xHost -ftz -fp-speculation=safe -fp-model source -- -i -p
CFLAGS=-O3 -xHost -ftz -fp-speculation=safe -fp-model source

@boegel boegel added the bug fix label Feb 9, 2021
@boegel boegel changed the title Don't reuse variable name in the loop Don't reuse variable name in the loop to fix adding extra compiler flags via toolchainopts Feb 9, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the 4.3.3 (next release) milestone Feb 9, 2021
@akesandgren
Copy link
Contributor

And yes it clearly fixes the problem.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @branfosj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants