Add support for BLIS+libFLAME toolchain #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akesandgren
requested changes
Nov 27, 2020
easybuild/toolchains/linalg/blis.py
Outdated
Comment on lines
54
to
55
| ver = LooseVersion(found_version) | ||
| if ver > LooseVersion('2.1'): |
There was a problem hiding this comment.
no need to create a variable if it's only used once, so reduce to
if LooseVersion(found_version) > LooseVersion('2.1'):
There was a problem hiding this comment.
Thanks for the comment! I changed it.
|
Going in, thanks @SebastianAchilles! |
|
Now we just need some easyconfigs to go with it... or are they already there? |
|
Yes, I create a PR for the easyconfigs: |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a toolchain using GNU with OpenMPI, BLIS, libFLAME, ScaLAPACK and FFTW.
I am not sure if the name
gobffis the best. I tried to be in line with the other naming of toolchains, likegoblf.