Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase functionality of try_toolchain #2539

Merged
merged 56 commits into from
Sep 21, 2018
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
d5ba7d6
Add support for including toolchains capabilities when creating toolc…
Jul 25, 2018
cb4904d
Update comment in tests
Jul 25, 2018
b0c5406
No bare excepts
Jul 25, 2018
5259b4a
No bare excepts
Jul 25, 2018
c7ddafe
Expand scope of get_toolchain_hierarchy without relying on build_options
Jul 26, 2018
21b3a53
Address style errors
Jul 26, 2018
d3aba89
Add tests for hierarchy to heirarchy mapping
Jul 26, 2018
46714a9
Be conservative with logic
Jul 26, 2018
4a86c2b
Remove hardcoded GCCcore name
Jul 26, 2018
a5f1d36
Allowing mapping up from GCCcore to another compiler (in the case whe…
Jul 26, 2018
69080d3
Allowing mapping up from GCCcore to another compiler (in the case whe…
Jul 27, 2018
7867ba9
Also grab binutils version built with GCCcore
Jul 30, 2018
444aea5
Style fixes
Jul 30, 2018
f256a32
Add missing easyconfig to test suite
Jul 30, 2018
619c9ff
Temporarily disable alternate method (to allow existing tests to pass)
Jul 30, 2018
9b20491
Add tests for mapping an easyconfig to new hierarchy
Jul 30, 2018
ee1eb88
Miscellaneous bug fixes
Jul 30, 2018
1d07e4a
Style fixes
Jul 30, 2018
9abfe53
Move careless dummy check placement
Jul 30, 2018
97e7d82
Move careless dummy check placement
Jul 30, 2018
9d25494
Make sure to add capabilities also to the parent toolchain
Jul 31, 2018
46a7f7f
Allow creation of tweaked toolchain easyconfig whenever there is an a…
Jul 31, 2018
eddc050
Always map deps if a map exists
Jul 31, 2018
e685231
Always map deps if a map exists
Jul 31, 2018
f003b17
Fix spacing of comments
Jul 31, 2018
a40c2d6
Fix spacing of comments
Jul 31, 2018
cc2168c
Fix more tests
Jul 31, 2018
53646aa
Fix style
Jul 31, 2018
b060dfa
Fall back to regex when things are too complicated
Jul 31, 2018
2073e38
Fi more tests
Jul 31, 2018
b46b093
Fix more tests
Jul 31, 2018
746471d
Fix last test
Jul 31, 2018
6c26f79
Remove stray print
Jul 31, 2018
133b4c7
Fix checking for key in dictionary
Jul 31, 2018
bb3bcde
Be more careful when using toolchain_mapping
Jul 31, 2018
a137e27
Merge branch 'develop' into increase_try_scope
Sep 10, 2018
dd0a7dd
Don't delete spaces
Sep 10, 2018
ae4d50e
Fix some tests
Sep 10, 2018
059a621
Fix another test
Sep 10, 2018
1cf9d36
Fix more tests
Sep 11, 2018
db1400a
Fix final test
Sep 11, 2018
583f047
Merge branch 'develop' into increase_try_scope
Sep 11, 2018
6c13972
Address some of the comments
Sep 11, 2018
1f1b03d
Address last of the comments
Sep 12, 2018
0965f9a
Address newer comments
Sep 12, 2018
5377ff8
Fix comments
Sep 12, 2018
61a0bcb
Fix more comments
Sep 12, 2018
14d80b7
Appease the hound
Sep 12, 2018
4d8b503
Address more comments
Sep 12, 2018
21a638c
Fix broken test
Sep 12, 2018
07384d5
Use more general test method
Sep 12, 2018
5569c50
Update tweak.py
Sep 14, 2018
b6942cc
Merge branch 'develop' into increase_try_scope
Sep 20, 2018
6c49a39
Merge branch 'increase_try_scope' of github.com:ocaisa/easybuild-fram…
Sep 20, 2018
67b816e
minor code cleanup
boegel Sep 21, 2018
6b627a0
Merge pull request #37 from boegel/increase_try_scope
Sep 21, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions easybuild/framework/easyconfig/easyconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,16 +115,16 @@ def toolchain_hierarchy_cache(func):
cache = {}

@functools.wraps(func)
def cache_aware_func(toolchain):
def cache_aware_func(toolchain, require_capabilities=False):
"""Look up toolchain hierarchy in cache first, determine and cache it if not available yet."""
cache_key = (toolchain['name'], toolchain['version'])
cache_key = (toolchain['name'], toolchain['version'], require_capabilities)

# fetch from cache if available, cache it if it's not
if cache_key in cache:
_log.debug("Using cache to return hierarchy for toolchain %s: %s", str(toolchain), cache[cache_key])
return cache[cache_key]
else:
toolchain_hierarchy = func(toolchain)
toolchain_hierarchy = func(toolchain, require_capabilities)
cache[cache_key] = toolchain_hierarchy
return cache[cache_key]

Expand All @@ -135,7 +135,7 @@ def cache_aware_func(toolchain):


@toolchain_hierarchy_cache
def get_toolchain_hierarchy(parent_toolchain):
def get_toolchain_hierarchy(parent_toolchain, require_capabilities=False):
"""
Determine list of subtoolchains for specified parent toolchain.
Result starts with the most minimal subtoolchains first, ends with specified toolchain.
Expand Down Expand Up @@ -234,6 +234,32 @@ def get_toolchain_hierarchy(parent_toolchain):
subtoolchain_name, subtoolchain_version = subtoolchains[current_tc_name], None
toolchain_hierarchy.insert(0, {'name': current_tc_name, 'version': current_tc_version})

# also add toolchain capabilities
if require_capabilities:
for toolchain in toolchain_hierarchy:
toolchain_class, _ = search_toolchain(toolchain['name'])
tc = toolchain_class(version=toolchain['version'])
try:
toolchain['compiler_family'] = tc.comp_family()
except EasyBuildError:
toolchain['compiler_family'] = None
try:
toolchain['mpi_family'] = tc.mpi_family()
except EasyBuildError:
toolchain['mpi_family'] = None
try:
toolchain['blas_family'] = tc.blas_family()
except EasyBuildError:
toolchain['blas_family'] = None
try:
toolchain['lapack_family'] = tc.lapack_family()
except EasyBuildError:
toolchain['lapack_family'] = None
if 'CUDA_CC' in tc.variables:
toolchain['cuda'] = True
else:
toolchain['cuda'] = None # Useful to have it consistent with the rest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least two spaces before inline comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least two spaces before inline comment


_log.info("Found toolchain hierarchy for toolchain %s: %s", parent_toolchain, toolchain_hierarchy)
return toolchain_hierarchy

Expand Down
64 changes: 63 additions & 1 deletion easybuild/framework/easyconfig/tweak.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@

from easybuild.framework.easyconfig.default import get_easyconfig_parameter_default
from easybuild.framework.easyconfig.easyconfig import EasyConfig, create_paths, process_easyconfig
from easybuild.framework.easyconfig.easyconfig import get_toolchain_hierarchy
from easybuild.tools.build_log import EasyBuildError, print_warning
from easybuild.tools.config import build_option
from easybuild.tools.filetools import read_file, write_file
Expand Down Expand Up @@ -183,7 +184,7 @@ def __repr__(self):
tweaks['checksums'] = []
_log.warning("Tweaking version: checksums cleared, verification disabled.")

# we need to treat list values seperately, i.e. we prepend to the current value (if any)
# we need to treat list values separately, i.e. we prepend to the current value (if any)
for (key, val) in tweaks.items():

if isinstance(val, list):
Expand Down Expand Up @@ -615,3 +616,64 @@ def obtain_ec_for(specs, paths, fp=None):
return res
else:
raise EasyBuildError("No easyconfig found for requested software, and also failed to generate one.")

def compare_toolchain_specs(source_tc_spec, target_tc_spec):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

"""
Compare whether a source and target toolchain have compatible characteristics

:param source_tc_spec: specs of source toolchain
:param target_tc_spec: specs of target toolchain
ocaisa marked this conversation as resolved.
Show resolved Hide resolved
"""
can_map = True
# Check they have same capabilities
for key in ['compiler_family', 'mpi_family','blas_family', 'lapack_family', 'cuda']:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace after ','

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace after ','

if target_tc_spec[key] is None and source_tc_spec[key] is not None:
ocaisa marked this conversation as resolved.
Show resolved Hide resolved
can_map = False
break

return can_map

def match_minimum_tc_specs(source_tc_spec, target_tc_hierarchy):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

"""
Match a source toolchain spec to the minimal corresponding toolchain in a target hierarchy

:param source_tc_spec: specs of source toolchain
:param target_tc_hierarchy: hierarchy of specs for target toolchain
"""
minimal_matching_toolchain = {}
# Do a complete loop so we always end up with the minimal value in the hierarchy
for target_tc_spec in target_tc_hierarchy:
if compare_toolchain_specs(source_tc_spec, target_tc_spec):
# GCCcore has compiler capabilities but should only be used if the original toolchain was also GCCcore
if source_tc_spec['name'] != 'GCCcore' and target_tc_spec['name'] == 'GCCcore':
minimal_matching_toolchain = {'name': target_tc_spec['name'], 'version': target_tc_spec['version']}
target_compiler_family = target_tc_spec['compiler_family']


if not minimal_matching_toolchain:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many blank lines (2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many blank lines (2)

EasyBuildError("No possible mapping from source toolchain spec %s and target toolchain hierarchy specs %s",
source_tc_spec, target_tc_hierarchy)

# Warn if we are changing compiler families, this is very likely to cause problems
if target_compiler_family != source_tc_spec['compiler_family']:
print_warning("Your request will results in a compiler family switch (%s to %s). Here be dragons!",
source_tc_spec['compiler_family'], target_compiler_family)


return minimal_matching_toolchain

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many blank lines (2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many blank lines (2)



def map_toolchain_hierarchies(source_toolchain, target_toolchain):
"""
Create a map between toolchain hierarchy of the initial toolchain and that of the target toolchain

:param source_toolchain: initial toolchain of the easyconfig(s)
:param target_toolchain: target toolchain for tweaked easyconfig(s)
ocaisa marked this conversation as resolved.
Show resolved Hide resolved
"""
tc_mapping = {}
initial_tc_hierarchy = get_toolchain_hierarchy(source_toolchain, require_capabilities=True)
ocaisa marked this conversation as resolved.
Show resolved Hide resolved
target_tc_hierarchy = get_toolchain_hierarchy(target_toolchain, require_capabilities=True)
for toolchain_spec in initial_tc_hierarchy:
tc_mapping[toolchain_spec['name']] = match_minimum_tc_specs(toolchain_spec, target_tc_hierarchy)

return tc_mapping

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

27 changes: 27 additions & 0 deletions test/framework/robot.py
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,33 @@ def test_get_toolchain_hierarchy(self):
{'name': 'iimpi', 'version': '5.5.3-GCC-4.8.3'},
])

# test also --try-toolchain* case, where we want more detailed information
init_config(build_options={
'valid_module_classes': module_classes(),
'robot_path': test_easyconfigs,
})

get_toolchain_hierarchy.clear()

goolf_hierarchy = get_toolchain_hierarchy({'name': 'goolf', 'version': '1.4.10'}, require_capabilities=True)
self.assertEqual(goolf_hierarchy, [
{'name': 'GCC', 'version': '4.7.2', 'compiler_family': 'GCC', 'mpi_family': None,
'lapack_family': None, 'blas_family': None, 'cuda': None},
{'name': 'gompi', 'version': '1.4.10', 'compiler_family': 'GCC', 'mpi_family': 'OpenMPI',
'lapack_family': None, 'blas_family': None, 'cuda': None},
{'name': 'goolf', 'version': '1.4.10', 'compiler_family': 'GCC', 'mpi_family': 'OpenMPI',
'lapack_family': 'OpenBLAS', 'blas_family': 'OpenBLAS', 'cuda': None},
])
ocaisa marked this conversation as resolved.
Show resolved Hide resolved

iimpi_hierarchy = get_toolchain_hierarchy({'name': 'iimpi', 'version': '5.5.3-GCC-4.8.3'},
require_capabilities=True)
self.assertEqual(iimpi_hierarchy, [
{'name': 'iccifort', 'version': '2013.5.192-GCC-4.8.3', 'compiler_family': 'Intel', 'mpi_family': None,
'lapack_family': None, 'blas_family': None, 'cuda': None},
{'name': 'iimpi', 'version': '5.5.3-GCC-4.8.3', 'compiler_family': 'Intel', 'mpi_family': 'IntelMPI',
'lapack_family': None, 'blas_family': None, 'cuda': None},
])

# test also including dummy
init_config(build_options={
'add_dummy_to_minimal_toolchains': True,
Expand Down