-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{tools}[system] pip v20.0.2 #9859
Conversation
Test report by @boegel |
Test report by @boegel |
Test report by @boegel |
'checksums': ['e5baf7723e5bb8382fc146e33032b241efc63314211a3a120aaa55d62d2bb008'], | ||
}), | ||
# stick to latest 0.33.x, 0.34.x does not work (UnicodeEncodeError, see https://github.com/pypa/wheel/issues/331) | ||
('wheel', '0.33.6', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposedly fixed in 0.34.2, why not use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using 0.34.2
, didn't work for me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not regret this later can we get a couple test reports with 34.2 first? Multiple people reported success with that so it might also be helpful for upstream and we have an easy way to get reproducible results from a couple environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I investigated a bit and found this to be solely a Python2 issue (I guess we'll see more of them), see pypa/wheel#331. A possible solution is to patch setuptools: pypa/setuptools#2003
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's worth the effort to patch setuptools
for this.
Also, I don't expect setuptools
to care much about Python 2 these days...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well they introduced a deprecation notice for 45.x with a promise to not drop it before April(?), so I'd wait a couple days for a response on the issue(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this a bit with the guys from setuptools and they were pretty clear that setup.py install
is no longer supported/deprecated and pip install
shall be used. Also this method of installing pip is not recommended and get-pip.py
shall be used instead. And indeed I was able to install all this with:
python get-pip.py --no-setuptools --no-wheel --ignore-installed --prefix /tmp/pipeb
PATH=/tmp/pipeb/bin PYTHONPATH=/tmp/pipeb/lib/python2.7/site-packages:$PYTHONPATH pip install --prefix=/tmp/pipeb setuptools==44.0.0
PATH=/tmp/pipeb/bin PYTHONPATH=/tmp/pipeb/lib/python2.7/site-packages:$PYTHONPATH pip install --prefix=/tmp/pipeb .
Hence my suggestion:
- use pip to install these packages
- when no pip is found (or always?), install the one from get-pip.py in the preinstallopts (e.g.), which will then be replaced by the one installed in the last step (pip installing pip)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel @Flamefire would be good to find a resolution for this one.
…asyconfigs into 20200212104757_new_pr_pip2002
Not planning to pursue this, installing on top of system Python is bloody painful to get right in every possible context, so closing.... |
(created using
eb --new-pr
)requires
easybuilders/easybuild-easyblocks#1961in caseeb
is run withpython3
butpython
is also available in the OS...