-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW) #2624
Conversation
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6763/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
('Tcl', '8.6.4'), # for tcltk | ||
('Tk', '8.6.4', versionsuffix), # for tcltk | ||
('cURL', '7.47.0'), # for RCurl | ||
('libxml2', '2.9.3', '-Python-2.7.11%s' % versionsuffix), # for XML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need libxml with Python bindings enabled?
if we can get around including Python as an (indirect) dep for R, I think we should?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel Not, but cairo
have a GLib
dependency, and GLib
have a libxml2-Python
dependency. So all the chain should have libxml2-Python
dependency to avoid conflicts (or we have to delete the Python
dependency of the existing GLib
easyconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a "dontload@build" option in case of Dependencies, so that dep is not loaded during the build. I mean, in case of GLlib
Python
is only a builddep, but we have to use libxml2
with Python
capabilities. libxml2
with Python
could be builddep, and normal libxml2
could be the dep, with "dontload@build"
This should help us to easier handle circular dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think using two different libxml2 builds as build dep/runtime dep is a good idea...
Who knows what happens during the build, it may remember where the libxml2 it was built on top of is installed.
Why do we have to use libxml2 w/ Python in GLib? And how can Python only be a build dep then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking the GLib
configure.log, only xmlcatalog
needed. And Indeed, Python
must be there to build GLib
there is no other way. Anyway, I am not 100% sure that we need libxml2
as dep for GLib
, but I also feel that this issue should not block this PR. (maybe I am wrong here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checking everything in bin and lib of a build I have of GLib/2.47.5
and there doesn't seem to be any dependency on libxml, I think it will work as a build dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling that GLib
does not need libxml2
at all. The only xml stuff I found there, is xmlcatalog. xml catalogs are pointing to xml documents, but anyway, we are not keen to install documentation. Moreover, not giving the --with-xml-catalog=CATALOG
option to configure
it defaults to /etc/xml/catalog
So probably libxml2 is not a real dep for GLib
How shoud we proceed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could try and see if GLib works without libxml2, on a setup where libxml2 is not provided by the OS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLib uses xmllint
at build time, which is provided by libxml2
, cfr. https://mail.gnome.org/archives/gtk-list/2013-April/msg00010.html
so, libxml2
is definitely a build dep
Test report by @boegel |
Test report by @boegel |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6777/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6778/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Sorry for the interruption here, but I have a question: Are we sure that the required dependency is libX11 and not libXt? I was building R these days also, and the easyconfig in the repo couldn't get built because of a missing libXt header. |
@damianam if you want X11 support, you need |
@hajgato, no, I took it from master, but it didn't build. However, after adding |
|
||
libx11 = 'libX11' | ||
libxver = '1.6.3' | ||
versionsuffix = '-%s-%s' % (libx11, libxver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel: I am on it, but because the GLib
-libxm2
issue, I need a GLib
with libxml2-Pyhon-libX11
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6811/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6812/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@boegel finished, |
Test report by @boegel |
Test report by @boegel |
@boegel |
Test report by @boegel |
Test report by @boegel |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6923/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Going in, thanks @hajgato! |
{lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW)
Needs #2621