Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[foss/2023a] Lightning v2.2.1 #21867

Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Nov 18, 2024

(created using eb --new-pr)

Same as #19964 without CUDA.

@lexming lexming added the update label Nov 18, 2024
Copy link

Updated software Lightning-2.2.1-foss-2023a.eb

Diff against Lightning-2.2.1-foss-2023a-CUDA-12.1.1.eb

easybuild/easyconfigs/l/Lightning/Lightning-2.2.1-foss-2023a-CUDA-12.1.1.eb

diff --git a/easybuild/easyconfigs/l/Lightning/Lightning-2.2.1-foss-2023a-CUDA-12.1.1.eb b/easybuild/easyconfigs/l/Lightning/Lightning-2.2.1-foss-2023a.eb
index f92fd73995..5635e783f7 100644
--- a/easybuild/easyconfigs/l/Lightning/Lightning-2.2.1-foss-2023a-CUDA-12.1.1.eb
+++ b/easybuild/easyconfigs/l/Lightning/Lightning-2.2.1-foss-2023a.eb
@@ -2,7 +2,6 @@ easyblock = 'PythonPackage'
 
 name = 'Lightning'
 version = '2.2.1'
-versionsuffix = '-CUDA-%(cudaver)s'
 
 homepage = 'https://github.com/Lightning-AI/pytorch-lightning'
 description = """
@@ -20,10 +19,9 @@ sources = [SOURCELOWER_TAR_GZ]
 checksums = ['b3e46d596b32cafd1fb9b21fdba1b1767df97b1af5cc702693d1c51df60b19aa']
 
 dependencies = [
-    ('CUDA', '12.1.1', '', SYSTEM),
     ('Python', '3.11.3'),
-    ('PyTorch', '2.1.2', '-CUDA-%(cudaver)s'),
-    ('PyTorch-Lightning', version, '-CUDA-%(cudaver)s'),
+    ('PyTorch', '2.1.2'),
+    ('PyTorch-Lightning', version),
 ]
 
 download_dep_fail = True

@lexming lexming force-pushed the 20241118143204_new_pr_Lightning221 branch from badbdb2 to 1185b32 Compare November 18, 2024 13:42
@github-actions github-actions bot removed the change label Nov 18, 2024
@lexming lexming added this to the release after 4.9.4 milestone Nov 18, 2024
@lexming
Copy link
Contributor Author

lexming commented Nov 18, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=21867 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21867 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14728

Test results coming soon (I hope)...

- notification for comment with ID 2483155555 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fab347e5b7a905cb1a8203d18d75be96 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Nov 18, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21867 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21867 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5291

Test results coming soon (I hope)...

- notification for comment with ID 2483171695 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/0d712b78ed547298350b65857651e27d for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Nov 22, 2024

Going in, thanks @lexming!

@smoors smoors merged commit 3275341 into easybuilders:develop Nov 22, 2024
10 checks passed
@lexming lexming deleted the 20241118143204_new_pr_Lightning221 branch November 22, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants