Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently fix homepage + source URL for HDF + h4toh5 #21134

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

hattom
Copy link
Contributor

@hattom hattom commented Aug 6, 2024

Implemented from #21131.

Not sure what the policy is regarding __archive__.
Not sure if the exact versions of h4toh5 are still there, but the site seems in principle there.

@boegel
Copy link
Member

boegel commented Aug 14, 2024

@hattom The least painful way forward here is probably to undo the changes to the archived easyconfigs, to make CI happy...

@boegel boegel added the bug fix label Aug 14, 2024
@boegel boegel added this to the release after 4.9.2 milestone Aug 14, 2024
@hattom
Copy link
Contributor Author

hattom commented Aug 16, 2024

@boegel -- done.
Squash or leave as-is?

Squash of:
* Change URLs
* revert archive changes
* Adding missing checksums
* h4toh5/2.2.2: Revert changes (no longer available upstream)
@hattom
Copy link
Contributor Author

hattom commented Aug 19, 2024

@boegel -- CI seems happy now. Anything else?

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Update remaining HDF URLs consistently fix homeage + source URL for HDF + h4toh5 Sep 7, 2024
@boegel boegel changed the title consistently fix homeage + source URL for HDF + h4toh5 consistently fix homepage + source URL for HDF + h4toh5 Sep 7, 2024
@boegel boegel merged commit 2e6eb2e into easybuilders:develop Sep 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants