Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ignored toolchainopts from SYSTEM toolchain easyconfigs #21035

Merged
merged 1 commit into from
Jul 25, 2024
Merged

remove ignored toolchainopts from SYSTEM toolchain easyconfigs #21035

merged 1 commit into from
Jul 25, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 23, 2024 •
edited
Loading

(created using eb --new-pr)

related to easybuilders/easybuild-framework#4584

@branfosj branfosj added this to the 5.0 milestone Jul 23, 2024
@branfosj branfosj mentioned this pull request Jul 23, 2024
Merged
@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 15 out of 15 (14 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/b1cc985c819cefe52c39bcbb398a1cc5 for a full test report.

ocaisa
ocaisa approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR means the easyconfigs now reflect reality (the toolchainopts were never used) and this will be enforced in future via easybuilders/easybuild-framework#4585

@easybuilders easybuilders deleted a comment from boegelbot Jul 25, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jul 25, 2024
@ocaisa
Copy link
Member

ocaisa commented Jul 25, 2024

Test report by @ocaisa
FAILED
Build succeeded for 13 out of 14 (14 easyconfigs in total)
login1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/ocaisa/37b75c6a4faac57fc73ac5e362103eaf for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Jul 25, 2024

LGTM, not holding this back because of an existing problem with the SYSYEM Perl easyconfig (likely system specific)

@ocaisa ocaisa merged commit c800880 into easybuilders:5.0.x Jul 25, 2024
7 checks passed
@branfosj branfosj deleted the 20240723155025_new_pr_bzip2108 branch July 25, 2024 12:22
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
code cleanup EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@branfosj @ocaisa @boegel