-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2020b] QIIME2 v2022.8 w/ Python 3.8.6 (WIP) #16945
{bio}[foss/2020b] QIIME2 v2022.8 w/ Python 3.8.6 (WIP) #16945
Conversation
…order to install their npm dist folders
This comment was marked as outdated.
This comment was marked as outdated.
hm, using the distributed pretrained classifiers requires scikit-learn 0.24.1 specifically (https://github.com/qiime2/docs/blob/master/source/data-resources.rst) not sure that's worth the dependency variant exception (would also affect scikit-bio and umap-learn) |
…asyconfigs into 20221219172529_new_pr_QIIME220228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@migueldiascosta tests fail because two different versions of numba and LLVM get pulled in the dependency tree:
- R > Mesa > LLVM-11
- umap-learn > numba-0.52 > LLVM-10
The easiest solution seems to be to upgrade umap-learn to v0.5.3 which is compatible with numba v0.53 and LLVM 11. I made a PR for it in #17161
@migueldiascosta: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/3963144339
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QIIME2 also depends on MAFFT. See https://docs.qiime2.org/2023.2/tutorials/moving-pictures/
@migueldiascosta: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/5186087489
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
this is still WIP, I'll check if newer versions of QIIME2 still have problems with Python > 3.8, if they don't I'll submit a PR with a more recent toolchain |
Nope, with QIIME2 2023.2 and Python 3.9.6 I still get e.g. $ qiime tools validate $EBROOTQIIME2/lib/python3.9/site-packages/q2_sample_classifier/tests/data/vaw.qza
Traceback (most recent call last):
File "$EBROOTQIIME2/lib/python3.9/site-packages/q2cli/builtin/tools.py", line 555, in validate
result = qiime2.sdk.Result.load(path)
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/sdk/result.py", line 79, in load
archiver = archive.Archiver.load(filepath)
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/core/archive/archiver.py", line 372, in load
ref = cls(data_path, process_alias, Format(rec), cache)
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/core/archive/format/v1.py", line 29, in __init__
super().__init__(archive_record)
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/core/archive/format/v0.py", line 72, in __init__
self.type = sdk.parse_type(type)
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/sdk/util.py", line 68, in parse_type
type_expr = _parse.ast_to_type(_parse.string_to_ast(string))
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/core/type/parse.py", line 32, in string_to_ast
return _expr(expr.value)
File "$EBROOTQIIME2/lib/python3.9/site-packages/qiime2/core/type/parse.py", line 47, in _expr
field_expr = expr.slice.value
AttributeError: 'Name' object has no attribute 'value'
There was a problem loading $EBROOTQIIME2/lib/python3.9/site-packages/q2_sample_classifier/tests/data/vaw.qza as a QIIME 2 Result:
'Name' object has no attribute 'value'
See above for debug info. (this works with Python 3.8.6) |
(created using
eb --new-pr
)requires:
{tools}[foss/2020b] umap-learn v0.4.6 w/ Python 3.8.6 #16942{tools}[foss/2020b] umap-learn v0.5.3 w/ Python 3.8.6 #17161(as mentioned in the linked PRs, the reason to use 2020b is that QIIME v2022.8 w/ Python >= 3.9 fails simple tasks, related to the Python
ast
module)