-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel,lib,system,tools}[GCCcore/11.3.0] IPython v8.5.0, libsodium v1.0.18, OpenPGM v5.2.122, ... w/ Python 3.10.4 #16251
{devel,lib,system,tools}[GCCcore/11.3.0] IPython v8.5.0, libsodium v1.0.18, OpenPGM v5.2.122, ... w/ Python 3.10.4 #16251
Conversation
…-GCCcore-11.3.0.eb, OpenPGM-5.2.122-GCCcore-11.3.0.eb, ZeroMQ-4.3.4-GCCcore-11.3.0.eb
6eab4be
to
7c6aac3
Compare
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1244254439 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1244265166 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegelbot |
@SebastianAchilles I am interested in this PR. Is there any reason it is still in draft? |
Test report by @schiotz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of extensions here could be updated if we wanted to. other than that, it looks good.
I see a few new dependencies, but trust you knew they were needed
This MR is in draft, because I can not update a few extensions to the latest release. The problem is that some newer Python extensions require This opens a fundamental question: do we want to support |
It seems to me that updating the Would it be bad to include a newer version of If I do not know these packages, so feel free to ignore me if it is obvious I don't know what I am talking about. :-) |
I'd be OK with just holding some versions back, and we can look into hatchling and whatnot for 2022b. |
I'm also interested in this PR :) Also not too familiar with what Poetry and Hatchling do though. @Micket solution would definitely be the quickest. And since we're already way into the 2nd half of 2022, I'd also be in favor of just getting 'a' |
Test report by @casparvl |
Test report by @casparvl |
Okay, you convinced me that it is okay to hold some versions back. ;-) I will mark this MR as ready. About adding |
Test report by @Micket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. To add to @Micket 's comment: I don't know which specific package pulls in lxml
, but BeautifulSoup
is pulled in by notebook
nowadays. I'm not sure where lxml
comes from though, it doesn't seem to be a dependency from any of the other listed packages - unless I overlooked something. Can you comment?
I did a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ generoso |
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1281169284 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @SebastianAchilles! |
(created using
eb --new-pr
)