Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{devel,lib,system,tools}[GCCcore/11.3.0] IPython v8.5.0, libsodium v1.0.18, OpenPGM v5.2.122, ... w/ Python 3.10.4 #16251

Conversation

SebastianAchilles
Copy link
Member

(created using eb --new-pr)

…-GCCcore-11.3.0.eb, OpenPGM-5.2.122-GCCcore-11.3.0.eb, ZeroMQ-4.3.4-GCCcore-11.3.0.eb
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 12, 2022
@SebastianAchilles SebastianAchilles marked this pull request as draft September 12, 2022 19:12
@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
zen2-ubuntu-eb - Linux Ubuntu 22.04, x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.4
See https://gist.github.com/4b957c4c2883fccc3b206dce35a8b95d for a full test report.

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bdw-opensuse-154 - Linux openSUSE Leap 15.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.15
See https://gist.github.com/c5cb25cee4e9203109c1fa5d05366335 for a full test report.

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16251 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16251 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9158

Test results coming soon (I hope)...

- notification for comment with ID 1244254439 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16251 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16251 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1639

Test results coming soon (I hope)...

- notification for comment with ID 1244265166 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (4 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/1ca71cb2144ad0e4a74bcbad05fbb967 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3a569e93cce99496043b8e94111f0000 for a full test report.

@schiotz
Copy link
Contributor

schiotz commented Oct 3, 2022

@SebastianAchilles I am interested in this PR. Is there any reason it is still in draft?

@schiotz
Copy link
Contributor

schiotz commented Oct 3, 2022

Test report by @schiotz
SUCCESS
Build succeeded for 7 out of 7 (4 easyconfigs in total)
slid.fysik.dtu.dk - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz, Python 2.7.5
See https://gist.github.com/bbca9c45c8cfef979ef53e3a28ef7ea1 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of extensions here could be updated if we wanted to. other than that, it looks good.
I see a few new dependencies, but trust you knew they were needed

@SebastianAchilles
Copy link
Member Author

This MR is in draft, because I can not update a few extensions to the latest release. The problem is that some newer Python extensions require hatchling as build backend. However, with our current Python we can not install hatchling, because of poetry 1.1.13.

This opens a fundamental question: do we want to support hatchling in 2022a? If yes, we would need to update Python. If no, we can not install some newer Python extensions.

@schiotz
Copy link
Contributor

schiotz commented Oct 13, 2022

However, with our current Python we can not install hatchling, because of poetry 1.1.13.

This opens a fundamental question: do we want to support hatchling in 2022a? If yes, we would need to update Python. If no, we can not install some newer Python extensions.

It seems to me that updating the Python package would lead to hard-to-debug errors, where people who have installed it before the update cannot install some packages, and others can.

Would it be bad to include a newer version of poetry in a package that require it? It is certainly a bit odd, but perhaps the lesser evil.

If hatchling is only needed to build a package, would it be possible to make a PythonBundle with hatchling and a newer poetry, and then use it as a build-dependency?

I do not know these packages, so feel free to ignore me if it is obvious I don't know what I am talking about. :-)

@Micket
Copy link
Contributor

Micket commented Oct 14, 2022

I'd be OK with just holding some versions back, and we can look into hatchling and whatnot for 2022b.

@casparvl
Copy link
Contributor

I'm also interested in this PR :) Also not too familiar with what Poetry and Hatchling do though. @Micket solution would definitely be the quickest. And since we're already way into the 2nd half of 2022, I'd also be in favor of just getting 'a' IPython EasyConfig in (i.e. this one), even if it uses a bit older versions for some packages.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
gcn27 - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz, 4 x NVIDIA NVIDIA A100-SXM4-40GB, 515.43.04, Python 3.6.8
See https://gist.github.com/7eba818f751fc505164846db69abbb06 for a full test report.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
software1.lisa.surfsara.nl - Linux debian 10.13, x86_64, Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz, Python 3.7.3
See https://gist.github.com/ae5f399f8d6db13a6902fb27eef365d8 for a full test report.

@SebastianAchilles
Copy link
Member Author

Okay, you convinced me that it is okay to hold some versions back. ;-) I will mark this MR as ready.

About adding hatchling to Python one possible solution could be this change (however I am not sure, if we want to apply the change or use it as input for a future Python): #16402

@Micket
Copy link
Contributor

Micket commented Oct 17, 2022

Test report by @Micket
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/a5a54e73192c8e4e9456ea3627de6619 for a full test report.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. To add to @Micket 's comment: I don't know which specific package pulls in lxml, but BeautifulSoup is pulled in by notebook nowadays. I'm not sure where lxml comes from though, it doesn't seem to be a dependency from any of the other listed packages - unless I overlooked something. Can you comment?

@Micket
Copy link
Contributor

Micket commented Oct 17, 2022

I did a pipdeptree on the build i just did. nbconvert depends on lxml and beautifulsoup4

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Oct 17, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=16251 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16251 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9303

Test results coming soon (I hope)...

- notification for comment with ID 1281169284 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6942b394ae007e6217869596cbc7535c for a full test report.

@Micket
Copy link
Contributor

Micket commented Oct 17, 2022

Going in, thanks @SebastianAchilles!

@Micket Micket merged commit 7116c18 into easybuilders:develop Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants