Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OpenSSL wrapper dependency for CMake 3.18.4 with system toolchain #15227

Merged

Conversation

sassy-crick
Copy link
Collaborator

(created using eb --new-pr)

@sassy-crick sassy-crick changed the title OpenSSL included instead of relying on OS one {devel}[system] CMake-3.18.4 Apr 1, 2022
@sassy-crick sassy-crick changed the title {devel}[system] CMake-3.18.4 {devel}[system] CMake 3.18.4 Apr 1, 2022
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Apr 4, 2022
@jfgrimm
Copy link
Member

jfgrimm commented Apr 5, 2022

Test report by @jfgrimm
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
himem05.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz (cascadelake), Python 3.6.8
See https://gist.github.com/84e804192bda08fc2393878ec5843c4d for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Apr 5, 2022

@sassy-crick I think OpenSSL has to be a runtime dependency, it's dynamically linked

@sassy-crick
Copy link
Collaborator Author

@sassy-crick I think OpenSSL has to be a runtime dependency, it's dynamically linked

@jfgrimm Yes, of course you are right! I have updated the file. Thanks!

@jfgrimm
Copy link
Member

jfgrimm commented Apr 6, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node094.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/f36e2264878513436cb3cb5889011949 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Apr 6, 2022

@boegelbot : please test @ generoso

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=15227 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15227 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8358

Test results coming soon (I hope)...

- notification for comment with ID 1090089687 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/300def76120f9aa60ff6e9288adf07bd for a full test report.

@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.5.5?) Apr 6, 2022
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Member

jfgrimm commented Apr 6, 2022

Going in, thanks @sassy-crick!

@jfgrimm jfgrimm merged commit e1b7f6c into easybuilders:develop Apr 6, 2022
@sassy-crick sassy-crick deleted the 20220401143831_new_pr_CMake3184 branch April 6, 2022 20:33
@boegel boegel changed the title {devel}[system] CMake 3.18.4 use OpenSSL wrapper dependency for CMake 3.18.4 with system toolchain Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants