Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade dependency on nodejs + use jupyter-server-proxy in jupyter-matlab-proxy and configurable-http-proxy easyconfigs using GCCcore/10.3.0 toolchain #14942

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Feb 4, 2022

(created using eb --new-pr)
Depends on

Changelog:

  • simplify jupyter-matlab-proxy by depending on the new jupyter-server-proxy
  • change the version of nodejs in jupyter-matlab-proxy and configurable-http-proxy to be in agreement with other easyconfigs in this toolchain (eg R)

@boegelbot

This comment was marked as outdated.

@lexming lexming changed the title use dependency on jupyter-server-proxy in jupyter-matlab-proxy downgrade dependency on nodejs and use jupyter-server-proxy in jupyter-matlab-proxy and configurable-http-proxy Feb 22, 2022
@lexming
Copy link
Contributor Author

lexming commented Feb 22, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14942 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14942 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8175

Test results coming soon (I hope)...

- notification for comment with ID 1048281455 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming
Copy link
Contributor Author

lexming commented Feb 22, 2022

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
node301.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/f72b02ac03207d6be6945cb9676632f8 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ef9dd66d951eff9ec9c87348a8c825fa for a full test report.

@boegel boegel added this to the next release (4.5.4?) milestone Mar 4, 2022
@boegel boegel changed the title downgrade dependency on nodejs and use jupyter-server-proxy in jupyter-matlab-proxy and configurable-http-proxy downgrade dependency on nodejs + use jupyter-server-proxy in jupyter-matlab-proxy and configurable-http-proxy easyconfigs using GCCcore/10.3.0 toolchain Mar 4, 2022
@boegel
Copy link
Member

boegel commented Mar 4, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
node2682.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/98440c1d831644725bbc114071a58d3d for a full test report.

@boegel
Copy link
Member

boegel commented Mar 4, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
node3502.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/2b7aba2465edce90ecd2314cc26f20f1 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 4, 2022

Going in, thanks @lexming!

@boegel boegel merged commit 5aaa7ce into easybuilders:develop Mar 4, 2022
@lexming lexming deleted the 20220204162608_new_pr_jupyter-matlab-proxy034 branch March 4, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants