-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneccessary workaround for missing version of OpenDataCube and Spyder for 2020+ toolchains #12757
Remove unneccessary workaround for missing version of OpenDataCube and Spyder for 2020+ toolchains #12757
Conversation
…d Spyer for 2020+ toolchains
Test report by @Flamefire |
@branfosj It's a small change and worth getting in soon so new ECs based on those existing ones won't have it. |
easybuild/easyconfigs/s/Spyder/Spyder-4.1.5-foss-2020a-Python-3.8.2.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/s/Spyder/Spyder-4.1.5-foss-2020a-Python-3.8.2.eb
Outdated
Show resolved
Hide resolved
@boegelbot please test @ generoso |
@branfosj: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 827516536 processed Message to humans: this is just bookkeeping information for me, |
Test report by @branfosj |
@Flamefire failures are:
Did I need to rebuild something else first? |
Test report by @boegelbot |
It might be possible that this is a bug with how we install pip&setuptools which I fixed at https://github.com/easybuilders/easybuild-easyconfigs/pull/12650/files#diff-f2778ba0368a4ffc9f51ce4387a33394d9558d72b8802f7d06199bb8e6c81243L53-L57 I'm testing that now again, what exactly that causes and will report back. If you got some time please check the EasyBlock PRs required for #12650 |
@branfosj After lot's of trouble-shooting I found the culprit: While it looks like we installed a recent I'm currently testing a change to the Python EB to set If you want to test that you could load your Python module (Python/3.8.2-GCCcore-9.3.0) and run |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @branfosj |
Successful build was after rebuilds of Python with easybuilders/easybuild-easyblocks#2388 and #12650. |
@boegelbot please test @ generoso |
@branfosj: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 841101800 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)I discovered this while checking #12522 for validity.
In short: for 2019b and earlier we need the workaround because setuptools_scm>=3.4 is required which we don't have there.
In 2020a we do have that, so all is fine.
We should generally check if either an updated setuptools (maybe as a build dep) solves problems like this or use the generic whl from PyPi as
pip install foo
is doing.