-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't add include/node to $CPATH in nodejs easyconfigs + tweak V8 easyconfigs accordingly #11845
Conversation
…s installations include OpenSSL header files) + tweak V8 easyconfigs accordingly
Test report by @boegel |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @Micket |
Test report by @lexming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My failed test with V8-3.2.0-foss-2019b-R-3.6.2.eb
is due to yet another checksum change in CRAN
checksums = [
('f575e07c6fefbc53a96e90bbb41ffdf67794cca797661eb97a6f52348ae20d7c',
'd2e9b8eb0e9cec76a5c3a8725f7cd50a53ac0d98d0c1ec69d2a943132a2d3eb6'),
]
Test report by @lexming |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 741031374 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 741634012 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @lexming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @boegel ! |
Because nodejs installations include OpenSSL header files, which causes trouble (see #11663 + jeroen/openssl#84).
Other easyconfigs that depend on
nodejs
don't need to be fixed because of these changes (I'll confirm that in the test report).