-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed ambiguous Ray easyconfigs to Ray-assembler and Ray-project #11727
Renamed ambiguous Ray easyconfigs to Ray-assembler and Ray-project #11727
Conversation
@Darkless012 thanks for doing this. |
I don't mind changing the archive so that it matches the name of non-archived configs. We have git history for actual history? |
easybuild/easyconfigs/r/Ray-project/Ray-project-0.8.4-foss-2019b-Python-3.7.4.eb
Show resolved
Hide resolved
easybuild/easyconfigs/r/Ray-assembler/Ray-assembler-2.3.1-iimpi-2019a.eb
Show resolved
Hide resolved
easybuild/easyconfigs/__archive__/r/Ray-assembler/Ray-assembler-2.3.1-intel-2015a.eb
Outdated
Show resolved
Hide resolved
There's little point to change archived easyconfigs, the whole reason we've archived them is because we won't maintain them (and they'll be removed in the next major release of EasyBuild). |
Test report by @boegel |
easybuild/easyconfigs/r/Ray-assembler/Ray-assembler-2.3.1-iimpi-2019a.eb
Outdated
Show resolved
Hide resolved
@Darkless012 thanks for fixing the name collision. Following the comments of previous reviewers I have removed the change to archived easyconfigs. I hope that you agree with this change. |
Test report by @lexming |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 735211711 processed Message to humans: this is just bookkeeping information for me, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel |
Test report by @boegelbot |
Renamed ambiguous Ray easyconfigs to be distinguishable.
More info in issue #10757