Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed ambiguous Ray easyconfigs to Ray-assembler and Ray-project #11727

Merged

Conversation

Darkless012
Copy link
Contributor

Renamed ambiguous Ray easyconfigs to be distinguishable.
More info in issue #10757

@smoors
Copy link
Contributor

smoors commented Nov 16, 2020

@Darkless012 thanks for doing this.
however, I'm not sure if it's a good idea to modify files in the archive since, to me, an archive is a sort of historical reference.
what do you think?

@Micket
Copy link
Contributor

Micket commented Nov 16, 2020

I don't mind changing the archive so that it matches the name of non-archived configs. We have git history for actual history?

@boegel
Copy link
Member

boegel commented Nov 19, 2020

There's little point to change archived easyconfigs, the whole reason we've archived them is because we won't maintain them (and they'll be removed in the next major release of EasyBuild).

@boegel boegel changed the title Renamed ambiguous Ray easyconfigs - fixes #10757 Renamed ambiguous Ray easyconfigs to Ray-assembler and Ray-project Nov 26, 2020
@boegel
Copy link
Member

boegel commented Nov 26, 2020

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
node2622.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/77a2ae2ff0f4121a0e38e35da3314898 for a full test report.

@lexming
Copy link
Contributor

lexming commented Nov 27, 2020

@Darkless012 thanks for fixing the name collision. Following the comments of previous reviewers I have removed the change to archived easyconfigs. I hope that you agree with this change.

@lexming
Copy link
Contributor

lexming commented Nov 27, 2020

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/7aa86578f2a5e0c2a1b8489dabc8357f for a full test report.

@boegel
Copy link
Member

boegel commented Nov 28, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11727 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11727 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9802

Test results coming soon (I hope)...

- notification for comment with ID 735211711 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel dismissed smoors’s stale review November 28, 2020 10:21

requested changes done

@boegel boegel merged commit 6ab5b45 into easybuilders:develop Nov 28, 2020
@boegel
Copy link
Member

boegel commented Nov 28, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2720.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/a25e53e8ee730033054cdc35b1d62c38 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d232cacc395626458d5271d417080042 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants