Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/10.2.0] configurable-http-proxy v4.2.1, nodejs v12.19.0, JupyterHub v1.1.0 w/ Python 3.8.6 #11558

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Oct 21, 2020

(created using eb --new-pr)
depends on #11536 (for Mako)
I intentionally didn't follow the old configs naming convention for JupyterHub

…nodejs-12.19.0-GCCcore-10.2.0.eb, JupyterHub-1.1.0-GCCcore-10.2.0.eb
@Micket Micket removed the new label Oct 21, 2020
@boegelbot

This comment has been minimized.

@easybuilders easybuilders deleted a comment from boegelbot Oct 22, 2020
@boegel boegel added this to the next release (4.3.1) milestone Oct 22, 2020
@Micket
Copy link
Contributor Author

Micket commented Oct 22, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=11558 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11558 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8195

Test results coming soon (I hope)...

- notification for comment with ID 714389179 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Oct 22, 2020

@Micket Should we rename the (ancient) jupyterhub easyconfigs to avoid having the same thing under two different names?

edit: see #11570

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor Author

Micket commented Oct 22, 2020

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
vera-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/c25f29a07a91504386311e7d34b56706 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4e9466522d87ad471d701208e73e5e55 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 22, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (3 easyconfigs in total)
node3109.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/c75a7666553d8b46b91414e0b93555b0 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 22, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (3 easyconfigs in total)
node3401.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/13ac98c9deec3d1571e06a577e86e175 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Oct 23, 2020

I think this is good to merge @boegel

@smoors
Copy link
Contributor

smoors commented Oct 23, 2020

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node379.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/372bebe9a59bb0f0bdb77f9bfe6670ac for a full test report.

@boegel
Copy link
Member

boegel commented Oct 24, 2020

Going in, thanks @Micket!

@boegel boegel merged commit a98b9fb into easybuilders:develop Oct 24, 2020

builddependencies = [
('binutils', '2.35'),
('Python', '3.8.6'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently nodejs still requires python2 at configure time... Fixed in #11679

@Micket Micket deleted the 20201022004658_new_pr_configurable-http-proxy421 branch April 21, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants