Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we start asking new PRs to use SYSTEM instead of True #16330

Closed
Micket opened this issue Sep 28, 2022 · 2 comments
Closed

Shall we start asking new PRs to use SYSTEM instead of True #16330

Micket opened this issue Sep 28, 2022 · 2 comments
Milestone

Comments

@Micket
Copy link
Contributor

Micket commented Sep 28, 2022

Going forward, we agreed that it's a good idea to start using SYSTEM instead of True for system level dependencies.

Discussed briefly on todays conf call, but I think it's best if we start by

  1. Doing a big PR where we at least change most of the recent stuff to use this. Otherwise, it will be an never-ending stream of new contributions that copy old stuff and then get asked to change it. Very annoying and a time waste.

  2. Have the CI check for this automatically.

@jfgrimm
Copy link
Member

jfgrimm commented Oct 12, 2022

Doing a big PR where we at least change most of the recent stuff to use this. Otherwise, it will be an never-ending stream of new contributions that copy old stuff and then get asked to change it. Very annoying and a time waste.

done in PR #16386, and a few that were originally missed (or merged in the meantime) in #16384

Have the CI check for this automatically.

addressed in #16384

A PR to update the easybuild documentation was also merged in easybuilders/easybuild#827, and instances in the framework tests updated in easybuilders/easybuild-framework#4094

kosl pushed a commit to kosl/easybuild-easyconfigs that referenced this issue Oct 18, 2022
kosl pushed a commit to kosl/easybuild-easyconfigs that referenced this issue Oct 18, 2022
zemu-unile added a commit to zemu-unile/easybuild-easyconfigs that referenced this issue Oct 21, 2022
DirectorSloan pushed a commit to Helmholtz-UFZ/easybuild-easyconfigs that referenced this issue Oct 31, 2022
DirectorSloan pushed a commit to Helmholtz-UFZ/easybuild-easyconfigs that referenced this issue Oct 31, 2022
@Micket
Copy link
Contributor Author

Micket commented Jan 14, 2023

we do this now (edit: see #16384)

@Micket Micket closed this as completed Jan 14, 2023
@boegel boegel added this to the 4.6.2 milestone Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants