Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PYPI_SOURCE constant in generic PythonPackage easyblock + custom easyblock for Python #3410

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Aug 14, 2024

@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Aug 19, 2024
@boegel boegel added this to the 5.0 milestone Aug 19, 2024
@boegel boegel changed the title Use new constant dicts instead of list use PYPI_SOURCE constant in generic PythonPackage easyblock + custom easyblock for Python Aug 27, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but requires that easybuilders/easybuild-framework#4595 is merged first)

@Micket
Copy link
Contributor

Micket commented Aug 29, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS cryptography-42.0.8-GCCcore-13.3.0.eb
  • SUCCESS Python-3.12.3-GCCcore-13.3.0.eb
  • SUCCESS Python-bundle-PyPI-2024.06-GCCcore-13.3.0.eb
  • SUCCESS Mako-1.3.5-GCCcore-13.3.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/75149b61849bb923d4984da7566645a1 for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 30, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

Build succeeded for 4 out of 5 (5 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/26d1d54923e367c8f896325afa14ba39 for a full test report.

(ignore that libtiff issue, new test report coming)

@Micket
Copy link
Contributor

Micket commented Aug 30, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS jbigkit-2.1-GCCcore-13.3.0.eb
  • SUCCESS NASM-2.16.03-GCCcore-13.3.0.eb
  • SUCCESS libjpeg-turbo-3.0.1-GCCcore-13.3.0.eb
  • SUCCESS libdeflate-1.20-GCCcore-13.3.0.eb
  • SUCCESS LibTIFF-4.6.0-GCCcore-13.3.0.eb

Build succeeded for 5 out of 5 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/7c44898133382cde1731f0331e5772d1 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 3fa6473 into easybuilders:5.0.x Aug 30, 2024
19 checks passed
@Flamefire Flamefire deleted the constants branch August 30, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants