-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge of the ConfigureMake and CMakeMake versions of the easyblock for QuantumESPRESSO #3338
Merge of the ConfigureMake and CMakeMake versions of the easyblock for QuantumESPRESSO #3338
Conversation
5617ae1
to
456e5d4
Compare
456e5d4
to
7f9134f
Compare
@boegel I tried merging the 2 easyblocks for QuantumESPRESSO into a new one acting as a wrapper and forwarding the calls to the correct EB based on the version. It is slightly hackish but still very clean code-wise. Unfortunately The alternatives would be to either define the classes inside something like another class (or the wrapper class itself) or a dict (anything that will let class not be at the beginning of the string to trick the Any suggestion in which direction to proceed? |
This is extensively tested in easybuilders/easybuild-easyconfigs#20070 and easybuilders/easybuild-easyconfigs#20138 |
…stem/site libraries to take precedence over EB ones
505eca8
to
f9df434
Compare
f9df434
to
5f95e61
Compare
Put version specific classes inside the wrapper as to not have trouble with framework EB detection regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been extensively tested via easybuilders/easybuild-easyconfigs#20138 and easybuilders/easybuild-easyconfigs#20070 (comment)
The QuantumESPRESSO
ConfigMake
andCMakeMake
easyblocks have been merged in the same file with a wrapper easyblock deciding which one will get used depending on the version of QE.This PR would