update make_module_* methods in OpenMPI easyblock to handle special cases for OpenMPI-CUDA #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akesandgren
added a commit
to akesandgren/easybuild-easyconfigs
that referenced
this pull request
Apr 20, 2022
boegel
changed the title
boegel
requested changes
May 11, 2022
| @@ -140,6 +140,31 @@ def test_step(self): | |||
|
|
|||
| super(EB_OpenMPI, self).test_step() | |||
|
|
|||
| def make_module_req_guess(self): | |||
| """Special case for OpenMPI-CUDA""" | |||
There was a problem hiding this comment.
@akesandgren This docstring should be fine-tuned a bit.
Although the current implementation only does specific stuff for the OpenMPI-CUDA case, that may not stay list this going forward.
The method docstring should just say something like "Tweaks to path guesses specific to OpenMPI.", and a comment should be added right above the if to explain why the PATH entry is removed, and why the OMPI_MCA_mca_component_path is added.
Similar remark for make_module_extra below.
That seems like a duplicate of what's being done here in make_module_req_guess, which are both needed?!
|
Not needed since we went with the OpenMPI+CUDA setup in easybuilders/easybuild-easyconfigs#15528 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)