-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix extension filter for Perl packages #2699
base: develop
Are you sure you want to change the base?
Conversation
Replaces #1449? Also, the comment on the line above will need to be updated. |
Spent a little bit more time on this, made some progress but not out of the woods yet with necessary changes to Changes to --- a/easybuild/easyconfigs/p/Perl/Perl-5.34.1-GCCcore-11.3.0.eb
+++ b/easybuild/easyconfigs/p/Perl/Perl-5.34.1-GCCcore-11.3.0.eb
@@ -989,6 +989,11 @@ exts_list = [
'source_urls': ['https://cpan.metacpan.org/authors/id/A/AS/ASPINELLI'],
'checksums': ['409a8e0e4b1025c8e80f628f65a9778aa77ab285161406ca4a6c097b13656d0d'],
}),
+ ('Pod::Parser', '1.65', {
+ 'source_tmpl': 'Pod-Parser-%(version)s.tar.gz',
+ 'source_urls': ['https://cpan.metacpan.org/authors/id/M/MA/MAREKR/'],
+ 'checksums': ['3ba7bdec659416a51fe2a7e59f0883e9c6a3b21bc9d001042c1d6a32d401b28a'],
+ }),
('Pod::LaTeX', '0.61', {
'source_tmpl': 'Pod-LaTeX-%(version)s.tar.gz',
'source_urls': ['https://cpan.metacpan.org/authors/id/T/TJ/TJENNESS'],
@@ -1590,6 +1595,7 @@ exts_list = [
'checksums': ['9841be5587bfb7cd1f2fe267b5e5ac04ce25e79d5cc77e5ef9a9c5abd101d7b1'],
}),
('Term::ReadLine::Gnu', '1.42', {
+ 'modulename': 'Term::ReadLine',
'source_tmpl': 'Term-ReadLine-Gnu-%(version)s.tar.gz',
'source_urls': ['https://cpan.metacpan.org/authors/id/H/HA/HAYASHI'],
'checksums': ['3c5f1281da2666777af0f34de0289564e6faa823aea54f3945c74c98e95a5e73'],
@@ -1640,6 +1646,7 @@ exts_list = [
'checksums': ['dbf7c827984951fb248907f940fd8f19f2696bc5545c0a15287e0fbe56a52308'],
}),
('if', '0.0608', {
+ 'modulename': False,
'source_tmpl': 'if-%(version)s.tar.gz',
'source_urls': ['https://cpan.metacpan.org/authors/id/X/XS/XSAWYERX'],
'checksums': ['37206e10919c4d99273020008a3581bf0947d364e859b8966521c3145b4b3700'], This is not enough though, since two checks are still failing:
|
As for the Bzip2 module it needs to be downgraded to 2.102, at the highest, to get it to require Compress::Raw::Bzip2 and Compress::Zlib versions 2.101 which are what comes internally in that Perl version. Testing locally with that now... And it actually solves the PDF::API2 problem too. |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1758312397 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
easybuilders/easybuild-easyconfigs#18789 helps a lot with making this viable to merge, but I just realized that fixing the I'm starting to think we should get this included with EasyBuild 5.0, since it will no doubt result in some breakage left and right (in easyconfigs we don't control) because we're stricter when testing the "import" of installed Perl modules. |
(created using
eb --new-pr
)The
perldoc
command we were using doesn't verify that all required dependenices of a Perl module are also available.This should not get merged straight away, a couple of minor fixes will need to be added to the
Perl
easyconfigs, including:Pod::Parser
extension;Term::ReadLine::Gnu
toTerm::ReadLine
(becauserequire Term::ReadLine::Gnu
triggers an error stating that it should not be used directly);'modulename': False
for theif
extension (which doesn't provide a Perl module in the traditional sense, but adds support for usinguse if
, cfr. https://metacpan.org/pod/if)