Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support to NAMD easyblock to opt out of building with CUDA support even if CUDA is included as dependency #2666

Merged
merged 2 commits into from
Feb 4, 2022
Merged

add support to NAMD easyblock to opt out of building with CUDA support even if CUDA is included as dependency #2666

merged 2 commits into from
Feb 4, 2022

Conversation

damianam
Copy link
Member

Useful when CUDA is part of the dependencies (like when included by MPI
or any other dependency), but we don't want to build Charm++ with CUDA
support

@damianam
To enable the enabling of CUDA as desired, instead of automatically.
2f1247d 
Useful when CUDA is part of the dependencies (like when included by MPI
or any other dependency), but we don't want to build Charm++ with CUDA
support
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Jan 29, 2022
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS NAMD-2.14-foss-2019b-mpi.eb
  • SUCCESS NAMD-2.14-foss-2020a-mpi.eb
  • SUCCESS NAMD-2.14-foss-2020b-mpi.eb
  • SUCCESS NAMD-2.14-intel-2020a-mpi.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
cnx1 - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0430664b16da798016151323c7ee4fbd for a full test report.

@boegel boegel changed the title NAMD easyblock: To enable the enabling of CUDA as desired, instead of automatically. add support to NAMD easyblock to opt out of building with CUDA support even if CUDA is included as dependency Jan 29, 2022
boegel
boegel previously requested changes Jan 29, 2022
View reviewed changes
easybuild/easyblocks/n/namd.py Outdated Show resolved Hide resolved
@boegel boegel modified the milestones: 4.x, next release (4.5.3?) Jan 29, 2022
@ocaisa ocaisa dismissed boegel’s stale review February 4, 2022 11:48

Requested changes addressed

ocaisa
ocaisa approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Member

ocaisa commented Feb 4, 2022

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS NAMD-2.14-foss-2019b-mpi.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 3.6.8
See https://gist.github.com/ccd6d6ffff025c394e35f6cdf71545da for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Feb 4, 2022

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS NAMD-2.14-foss-2020a-mpi.eb
  • SUCCESS NAMD-2.14-intel-2020a-mpi.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
login1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 3.6.8
See https://gist.github.com/a729693ebcac792576d1f2a77b6e451e for a full test report.

@ocaisa ocaisa merged commit ba0e745 into easybuilders:develop Feb 4, 2022
@boegel boegel mentioned this pull request Feb 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

@boegel boegel boegel left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@damianam @SebastianAchilles @ocaisa @boegel