Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SAMtools easyblock to support installation of SAMtools 1.14 #2620

Merged

Conversation

sassy-crick
Copy link
Contributor

(created using eb --new-pr)

@sassy-crick
Copy link
Contributor Author

The latest SAMtools 1.14 has removed some old files from the build as explained here
This updated EasyBlock addresses these changes.
I tested it as low as SAMtools-1.10-GCC-9.3.0.eb and that seems to have worked, after putting self.lib_files [] in the right line.

@sassy-crick sassy-crick changed the title Updated to reflect changes in 1.14 Updated to reflect changes in SAMTools 1.14 Nov 15, 2021
@boegel boegel added the update label Nov 24, 2021
@boegel boegel added this to the 4.x milestone Nov 24, 2021
@boegel boegel changed the title Updated to reflect changes in SAMTools 1.14 update SAMtools easyblock to support installationg of SAMtools 1.14 Nov 24, 2021
@boegel boegel changed the title update SAMtools easyblock to support installationg of SAMtools 1.14 update SAMtools easyblock to support installation of SAMtools 1.14 Nov 24, 2021
@boegel
Copy link
Member

boegel commented Nov 24, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS SAMtools-1.10-GCC-9.3.0.eb
  • SUCCESS SAMtools-1.11-GCC-10.2.0.eb
  • SUCCESS SAMtools-1.11-GCC-9.3.0.eb
  • SUCCESS SAMtools-1.12-GCC-10.3.0.eb
  • SUCCESS SAMtools-1.12-GCC-9.3.0.eb
  • SUCCESS SAMtools-1.13-GCC-10.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/db472722b2ccd1934b002389de4868c5 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.5.1?) Nov 24, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 58c568f into easybuilders:develop Nov 24, 2021
@sassy-crick sassy-crick deleted the 20211115173642_new_pr_samtools branch November 25, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants