Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use explicit build toolset and compiler path in Boost easyblock #2402

Merged
merged 3 commits into from
May 25, 2021
Merged

use explicit build toolset and compiler path in Boost easyblock #2402

merged 3 commits into from
May 25, 2021

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Apr 27, 2021 •
edited
Loading

(created using eb --new-pr)

Fixes easybuilders/easybuild#695

@zao
Copy link
Contributor

zao commented Apr 27, 2021

Test report by @zao

Overview of tested easyconfigs (in order)

  • SUCCESS Boost-1.75.0-GCC-10.2.0.eb
  • SUCCESS Boost-1.75.0-iccifort-2020.4.304.eb
  • SUCCESS Boost-1.76.0-iccifort-2020.4.304.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
eb-u2004 - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz, Python 3.8.5
See https://gist.github.com/a79526fdb18a62eef19edc70f32a7f56 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS Boost-1.70.0-gompi-2019a.eb
  • SUCCESS Boost-1.67.0-foss-2018b.eb
  • SUCCESS Boost-1.68.0-intel-2018b-Python-3.6.6.eb
  • SUCCESS Boost-1.71.0-gompi-2019b.eb
  • SUCCESS Boost-1.71.0-iimpi-2019b.eb
  • SUCCESS Boost-1.72.0-gompi-2020a.eb
  • SUCCESS Boost-1.74.0-GCC-10.2.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
taurusa11 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/94b0d569acff8e34938da92adb4da51d for a full test report.

@boegel boegel changed the title [Boost] Use explicit build toolset and compiler path use explicit build toolset and compiler path in Boost easyblock Apr 28, 2021
@boegel boegel added the bug fix label Apr 28, 2021
@boegel boegel added this to the next release (4.3.5?) milestone Apr 28, 2021
@Flamefire
Copy link
Contributor Author

@zao @boegel Ping. Do you need any more reports or anything?
This should go into the next release because some are blocked by this.

akesandgren
akesandgren previously approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one more thing, ignore this review

akesandgren
akesandgren reviewed May 24, 2021
View reviewed changes
easybuild/easyblocks/b/boost.py
# Check if using a Cray toolchain and configure MPI accordingly
if self.toolchain.toolchain_family() == toolchain.CRAYPE:
if self.toolchain.PRGENV_MODULE_NAME_SUFFIX == 'gnu':
craympichdir = os.getenv('CRAY_MPICH2_DIR')
craygccversion = os.getenv('GCC_VERSION')
txt = '\n'.join([
user_config.extend([
'local CRAY_MPICH2_DIR = %s ;' % craympichdir,
'using gcc ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this conflict with the toolset setting above? i.e. the user_config.append...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, maybe the last one wins... But added code to remove it and also check that it is actually used

@akesandgren akesandgren self-requested a review May 24, 2021 11:21
@akesandgren akesandgren dismissed their stale review May 24, 2021 11:22

Found one more possible problem

@akesandgren akesandgren removed their request for review May 24, 2021 11:22
@Flamefire Flamefire dismissed a stale review via 043fcff May 25, 2021 09:36
akesandgren
akesandgren approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @Flamefire!

@akesandgren akesandgren merged commit 0c8258f into easybuilders:develop May 25, 2021
@Flamefire Flamefire deleted the 20210427141216_new_pr_lhmgfcewOI branch May 25, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Boost 1.76 with iccifort-2020.4.304 failing
4 participants
@Flamefire @zao @akesandgren @boegel