Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hardcoded path in NVHPC easyblock to support multiple architectures #2233

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

nordmoen
Copy link
Contributor

The nvhpc.py file contained one hardcoded path which hindered it from
working on multiple architectures.

The `nvhpc.py` file contained one hardcoded path which hindered it from
working on multiple architectures.
nordmoen pushed a commit to nordmoen/easybuild-easyconfigs that referenced this pull request Nov 12, 2020
Added new multi-arch version of NVHPC, this requires `easyblock` PR
easybuilders/easybuild-easyblocks#2233.
@Micket Micket added the bug fix label Nov 12, 2020
@Micket Micket added this to the 4.3.2 milestone Nov 12, 2020
@nordmoen
Copy link
Contributor Author

@Micket Any thoughts on this?

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title [NVHPC] Fixed hardcoded path to support multiple architectures fix hardcoded path in NVHPC easyblock to support multiple architectures Dec 8, 2020
@boegel
Copy link
Member

boegel commented Dec 8, 2020

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS NVHPC-20.7.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2610.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/3de51b45983cbda33b46d7a8c2b947f0 for a full test report.

@boegel boegel merged commit 909e38f into easybuilders:develop Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants