Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow wxPython to be installed as an extension #2227

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

mboisson
Copy link
Contributor

@mboisson mboisson commented Nov 10, 2020

Also using the 'build wheel + pip install wheel' mechanism, as otherwise, it would ignore the install prefix

…ld wheel + pip install wheel' mechanism, as otherwise, it would ignore the install prefix
@boegel boegel changed the title Allowed wxPython to be installed as an extension. Also using the 'bui… Allowed wxPython to be installed as an extension Nov 11, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 11, 2020
@boegel boegel changed the title Allowed wxPython to be installed as an extension allow wxPython to be installed as an extension Nov 11, 2020
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @mboisson!

@akesandgren akesandgren merged commit 5081b20 into easybuilders:develop Nov 23, 2020
@mboisson mboisson deleted the wxpython_fix branch November 23, 2020 15:31
@boegel
Copy link
Member

boegel commented Nov 28, 2020

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS wxPython-4.0.4-GCC-8.2.0-2.31.1-Python-3.7.2.eb
  • SUCCESS wxPython-4.0.4-GCC-8.2.0-2.31.1-Python-2.7.15.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2643.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2bf6852896734bd274969da3e7a17230 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 28, 2020

The changes made here seem to be breaking the installation of wxPython-4.0.7.post2-GCC-8.3.0-Python-3.7.4.eb (which installs fine with EasyBuild v4.3.1). The sanity check fails because .so symlinks are missing in the installation:

== sanity checking...
...
  >> file 'lib/python3.7/site-packages/wx/libwx_baseu-3.0.so' found: FAILED
  >> file 'lib/python3.7/site-packages/wx/libwx_gtk3u_core-3.0.so' found: FAILED

Can someone confirm this?

@mboisson
Copy link
Contributor Author

mboisson commented Nov 30, 2020

Mmm, these symlinks are indeed not in the lib/pythonX.Y/site-packages/wx/ folders, they are in the lib folder. I guess the sanity_checks have to be changed depending on the installation method ?

@boegel
Copy link
Member

boegel commented Nov 30, 2020

Not that it's only a problem for wxPython-4.0.7, the wxPython-4.0.4 easyconfigs still work fine?!

Do you mind opening a PR to fix this before we fork off things for the EasyBuild v4.3.2 (which we'll do tomorrow or Wed)?

@mboisson
Copy link
Contributor Author

mboisson commented Nov 30, 2020

Mmm, well I'm not in a situation to be able to test those EasyConfigs directly (I don't have this GCC, nor those versions of python)... The EasyConfig in which I used this is one for wxWidgets in which wxPython is installed as multi_deps extension.

I thought it might be just because the installation methods are not the same, and therefore result in different symlinks, but that it does not work for 4.0.7, but does for 4.0.4, that is mind-boggling.

@boegel
Copy link
Member

boegel commented Nov 30, 2020

Let's follow up in easybuilders/easybuild-easyconfigs#11790, it's too difficult to follow up on problems in merged PRs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants