add custom easyblock for Metagenome-Atlas #2219
Conversation
There was a problem hiding this comment.
@Darkless012 There's a lot of stuff in here that should probably be proper *.py files that come along with the easyconfig file rather than the easyblock (so they can be tweaked easily for specific versions of Metagenome-Atlas)...
It should also be clear where those scripts come from
| cluster-status: "slurm_status.py" # | ||
| max-jobs-per-second: 10 | ||
| max-status-checks-per-second: 10 | ||
| cores: 99 # how many jobs you want to submit to your cluster queue |
There was a problem hiding this comment.
Why 99? Is this just a default value? If so, use 1 as default?
Also cores vs "how many jobs" doesn't match?
There was a problem hiding this comment.
The script is plain copy from the template. Will change that to 1.
| system: "slurm" #check if system is defined below | ||
|
|
||
| slurm: | ||
| command: "sbatch --parsable" |
There was a problem hiding this comment.
Where does this come from, did you have to compose this yourself?
There was a problem hiding this comment.
This is also taken straight from the template.
https://github.com/metagenome-atlas/clusterprofile/blob/master/{{cookiecutter.profile_name}}/key_mapping.yaml
There was a problem hiding this comment.
Please include some comments above the constants to explain where this stuff comes from
Seems like we should be pointing to https://github.com/metagenome-atlas/clusterprofile/tree/master/%7B%7Bcookiecutter.profile_name%7D%7D, perhaps also to some documentation?
boegel
changed the title
No description provided.