Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't let extract_file change directory in various easyblocks #2051

Merged
merged 8 commits into from
May 1, 2020
Merged

don't let extract_file change directory in various easyblocks #2051

merged 8 commits into from
May 1, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented May 1, 2020

requires easybuilders/easybuild-framework#3292 where implicit changing of directory in extract_file was deprecated

@boegel boegel added this to the next release (4.2.1?) milestone May 1, 2020
@boegel boegel mentioned this pull request May 1, 2020
Merged
akesandgren
akesandgren approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit b6cd9ed into easybuilders:develop May 1, 2020
@boegel boegel deleted the extract_file branch May 1, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix change
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @akesandgren