Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance GCC easyblock to also put symlinks for cc/c++/f77/f95 in place #1256

Merged
merged 4 commits into from
Sep 20, 2017

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 19, 2017

fix for #507

@akesandgren
Copy link
Contributor

I would personally not do the chdir in and out, and instead change the symlink to:
symlink(comp_cmd_symlinks[key], target, ... instead. To avoid the basename call and still keep the symlink short-relative

@boegel
Copy link
Member Author

boegel commented Sep 20, 2017

Thanks for the suggestion @akesandgren!

Retested, works like a charm:

$ ls -l $EBROOTGCCCORE/bin | egrep ' cc| c\+\+| f77 | f95'
-rwxr-xr-x 4 vsc40023 vsc40023 4566920 Sep 20 15:36 c++
lrwxrwxrwx 1 vsc40023 vsc40023       3 Sep 20 15:36 cc -> gcc
lrwxrwxrwx 1 vsc40023 vsc40023       8 Sep 20 15:36 f77 -> gfortran
lrwxrwxrwx 1 vsc40023 vsc40023       8 Sep 20 15:36 f95 -> gfortran

@akesandgren
Copy link
Contributor

old_cmds should be taken from comp_cmd_symlinks and not written twice in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants