Added jhbuild easyblock #1004
Closed
Added jhbuild easyblock #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianam
commented
Jan 30, 2017
| def __init__(self, *args, **kwargs): | ||
| """Skip the install step.""" | ||
| super(EB_jhbuild, self).__init__(*args, **kwargs) | ||
| self.cfg['skipsteps'] = "install" |
There was a problem hiding this comment.
I believe this is a bug that will create a broken dumped file, with skipsteps = 'install' instead of skipsteps = ['install']
|
@boegel I guess this one won't make it to 3.1.0, right? |
|
@boegel, what should we do with this? It is not that useful for us anymore since we use your |
|
@damianam Well, if it's not going to be used we should close the PR? If we ever need to get back to it, we can revisit this PR... |
|
Sounds reasonable. I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a jhbuild easyblock. Useful for installing a variety of packages (X.Org, GTK, GIMP, etc). A test PR in https://github.com/hpcugent/easybuild-easyconfigs will follow (next week). This is a first step to clean easybuilders/easybuild-easyconfigs#3463
Test easyconfig PR: easybuilders/easybuild-easyconfigs#3641