Skip to content

Commit

Permalink
Only enable download_dep_fail by default for Python >= 2.7.14 for bac…
Browse files Browse the repository at this point in the history
…kwards compat
  • Loading branch information
Flamefire committed May 4, 2021
1 parent 6c7a190 commit ba31239
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion easybuild/easyblocks/p/python.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,12 @@ def __init__(self, *args, **kwargs):
easybuild_subdir = log_path()
self.pythonpath = os.path.join(easybuild_subdir, 'python')

# Some older ECs break if we enable download_dep_fail due to missing packages
# Since Python 2.7.14 (and all Python 3 versions) we usually enable download_dep_fail in the ECs
# already so this should not lead to failures
download_dep_fail_default = LooseVersion(self.version) >= LooseVersion('2.7.14')
ext_defaults = {
'download_dep_fail': True,
'download_dep_fail': download_dep_fail_default,
# The only installed packages at this point are default installed ones, e.g. pip&setuptools
# And we want to upgrade them cleanly, i.e. uninstall them
'pip_ignore_installed': False,
Expand Down

0 comments on commit ba31239

Please sign in to comment.