Skip to content

Commit

Permalink
When configuring experiment runs, domains will no longer be implicitl…
Browse files Browse the repository at this point in the history
…y expanded but must be explicitly defined.
  • Loading branch information
bojan-karlas committed May 22, 2024
1 parent 6cf2631 commit e5bbf7b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions experiments/datascope/experiments/bench/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ def get_instances(cls: Type["Scenario"], **kwargs: Any) -> Iterable["Scenario"]:
domain = [domain]
domains.append(list(domain))
else:
domains.append(list(attribute_descriptors[name].domain))
domains.append([None])
for values in product(*domains):
attributes = dict((name, value) for (name, value) in zip(names, values) if value is not None)
composed_attributes = cls._compose_attributes(attributes)
Expand Down Expand Up @@ -1010,7 +1010,7 @@ def df(self):
df = pd.DataFrame.from_dict({a: [x.get(a, None) for x in data] for a in self._attributes})
if self._key is not None:
df.set_index(self._key, inplace=True)
return df
return df.dropna(axis=1, how="all")

def __repr__(self) -> str:
return self.df.__repr__()
Expand Down

0 comments on commit e5bbf7b

Please sign in to comment.