Add Tracing DisableReport config item #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jthann , thanks for the pr, I'm fine with the code changes, please also help update the documentation to include the new option: https://github.com/megaease/easegress/blob/main/doc/reference/controllers.md#zipkinspec |
localvar
approved these changes
Aug 2, 2022
suchen-sci
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue735 enhancement
Notes: Cannot pass nil parameter to NewTracer function，because internally it will set t.noop = 1
and disable all zipkin function including generating TraceId，we just disable report function，so we need to create zipkin
reporter.NewNoopReporter()manually and pass toNewTracerfunction