Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #711: Nacos registry doesn't work #720

Merged
merged 1 commit into from
Jul 29, 2022
Merged

fix issue #711: Nacos registry doesn't work #720

merged 1 commit into from
Jul 29, 2022

Conversation

localvar
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #720 (e617a11) into main (d9ad9d6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   80.14%   80.14%   -0.01%     
==========================================
  Files          95       95              
  Lines       10647    10652       +5     
==========================================
+ Hits         8533     8537       +4     
- Misses       1621     1624       +3     
+ Partials      493      491       -2     
Impacted Files Coverage Δ
pkg/filters/proxy/pool.go 61.14% <0.00%> (-0.85%) ⬇️
pkg/filters/headerlookup/headerlookup.go 84.61% <0.00%> (-1.40%) ⬇️
pkg/cluster/cluster.go 60.10% <0.00%> (+0.52%) ⬆️
pkg/filters/validator/basicauth.go 78.80% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085130a...e617a11. Read the comment docs.

@localvar
Copy link
Collaborator Author

@jthann , please help check if this pr fix #711 .

@xxx7xxxx xxx7xxxx merged commit 7d9f590 into easegress-io:main Jul 29, 2022
@localvar localvar deleted the issue-711 branch July 29, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants