Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(easemonitormetrics): fix status convert error #583

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

aniaan
Copy link
Collaborator

@aniaan aniaan commented Apr 14, 2022

releated: #542

Due to the cutting, the current record value has no StatusInSameNamespace, and is replaced by a more fine-grained HttpServerStatus and httpPipelineStatus

cc @samutamm

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #583 (3e7a684) into main (d8446a7) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   80.06%   80.10%   +0.03%     
==========================================
  Files          95       95              
  Lines       10940    10940              
==========================================
+ Hits         8759     8763       +4     
+ Misses       1704     1701       -3     
+ Partials      477      476       -1     
Impacted Files Coverage Δ
pkg/object/autocertmanager/autocertmanager.go 94.28% <0.00%> (+0.81%) ⬆️
pkg/object/mqttproxy/client.go 80.54% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8446a7...3e7a684. Read the comment docs.

@samutamm samutamm merged commit b92261f into easegress-io:main Apr 15, 2022
@aniaan aniaan deleted the fix/monitor-error branch April 19, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants