Make PersistentVolume local path configurable #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchen-sci
reviewed
Sep 14, 2023
| @@ -13,7 +13,7 @@ spec: | |||
| persistentVolumeReclaimPolicy: Delete | |||
| storageClassName: easegress-storage | |||
| local: | |||
| path: /opt/easegress | |||
| path: {{ $.Values.cluster.volumeLocalPath }} | |||
There was a problem hiding this comment.
suggest to remove the $ sign and use {{ .Values.cluster.volumeLocalPath }} instead. To keep same format in all yamls.
There was a problem hiding this comment.
In the range block, {{ .Values.xxx }} doesn't work. I change to define another variable.
There was a problem hiding this comment.
Cool, lesson learned. Look good to me.
suchen-sci
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.