-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add support for Python 3.12 #1008
Conversation
NoteThere is a warning at run #6213169937, but the installation process succeeded, and software testing proceeds.
SolutionRelax the constraint over here. Lines 101 to 102 in de40c3b
|
This comment was marked as outdated.
This comment was marked as outdated.
161de61
to
f0fd349
Compare
d8e6098
to
0bdd184
Compare
f0fd349
to
9056c7d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 90.41% 90.82% +0.40%
==========================================
Files 103 103
Lines 9828 9828
Branches 1128 1128
==========================================
+ Hits 8886 8926 +40
+ Misses 747 706 -41
- Partials 195 196 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fbc2c48
to
0990f31
Compare
Apparently, the installation of the geojson package fails on Python 3.12, so we reported it to the upstream maintainers, and submitted a fix. |
0990f31
to
7b25dc2
Compare
The patch jazzband/geojson#222 has been merged, but geojson release is yet pending. |
f2a287d
to
37974b1
Compare
37974b1
to
816ce74
Compare
Observations Ih5py is failing to be pulled in on Python 3.12.
Observations IIOn the other hand, it looks like wheel packages for Python 3.12 are available since Oct 9, 2023. -- https://pypi.org/project/h5py/#files Action?We will probably need to relax this version constraint. h5py = { version = ">=3.1,<3.10", optional = true} -- https://github.com/earthobservations/wetterdienst/blob/v0.64.0/pyproject.toml#L199 |
ae87457
to
17b12ae
Compare
816ce74
to
378c0c1
Compare
07934b8
to
a9ce842
Compare
378c0c1
to
b55e88a
Compare
Yes, I suggest we skip duckdb installation in CI under 3.12 and make the duckdb test fully optional (I guess it is already?!). |
526d574
to
0a11b56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks for taking care, Benjamin. I've just added a suggestion about the test skipping.
0a11b56
to
bec30f8
Compare
bec30f8
to
756357b
Compare
About
Trying to bring in support for Python 3.12,
to bereleased on 2023-10-02 1.Details
NumPy compatibility for Python 3.12 (numpy/numpy#23808) is probably only one step-stone towards Python 3.12.
The build will probably fail due to various other reasons.Footnotes
https://devguide.python.org/versions/ ↩