This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Create locking mechanism to allow for sequential execs #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create two magic-string args for specifying lock and unlock ops. Locks are referenced with a string name, additional locks on a previously locked lock of the same name are ignored. Signed-off-by: Alex Couture-Beil <[email protected]>
vladaionescu
approved these changes
Jun 17, 2021
| select { | ||
| case <-l.ctx.Done(): | ||
| // unlock locks from closed connections | ||
| l.current = "" |
There was a problem hiding this comment.
Not sure if this is absolutely needed - but feel like there might be an edge case that we could be missing?
Suggested change
| l.current = "" | |
| l.current = "" | |
| l.ctx = nil |
|
Is this still ongoing? |
It's on the backburner, but still needs the context-aware lock to unlock if the session is lost/prematurely disconnected. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create two magic-string args for specifying lock and unlock ops.
Locks are referenced with a string name, additional locks on a
previously locked lock of the same name are ignored.
Signed-off-by: Alex Couture-Beil [email protected]