Issue 89 #90
Draft
Issue 89 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MCD12Q1 is not a burned area product, it's a landcover product. If the
landcover product we're using is also out of date we should also change
that though
…On Wed, Sep 13, 2023 at 3:05 PM Erick Verleye ***@***.***> wrote:
I updated the URLs in functions and main to
https://e4ftl01.cr.usgs.gov/MOTA/MCD12Q1.061/. Dockerfile has base image
updated and environment.yml has versions added to the packages. I pushed a
new Docker image to earthlabcu/firedpy:issue_89 and tested it out on Samoa.
If it checks out with @admahood <https://github.com/admahood> , I'll
change the tag to latest.
------------------------------
You can view, comment on, or merge this pull request online at:
#90
Commit Summary
- 1611f62
<1611f62>
Updating burned product URL everywhere to v 061
- ad6a94c
<ad6a94c>
Updating dockerfile and environment.yml with versions
File Changes
(4 files <https://github.com/earthlab/firedpy/pull/90/files>)
- *M* Dockerfile
<https://github.com/earthlab/firedpy/pull/90/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557>
(23)
- *M* environment.yaml
<https://github.com/earthlab/firedpy/pull/90/files#diff-0ff3348ae0de662ef053d7de057a7a92c091a09fc3d245c8da02bec028ca3d0b>
(40)
- *M* firedpy/__main__.py
<https://github.com/earthlab/firedpy/pull/90/files#diff-9acf8676e1ae66d257d76d13ebf70f09be009902d249ba0e67670f3377e18b2e>
(2)
- *M* firedpy/functions.py
<https://github.com/earthlab/firedpy/pull/90/files#diff-b67374bcf75d52e523b7a51d4a873285b6fc1478e3f6dd28b6f68af585ed3274>
(4)
Patch Links:
- https://github.com/earthlab/firedpy/pull/90.patch
- https://github.com/earthlab/firedpy/pull/90.diff
—
Reply to this email directly, view it on GitHub
<#90>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXI3P7IEDPBIDXUVZP2OBTX2INZ3ANCNFSM6AAAAAA4XDAKEQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
But the existing path essentially just needs to have a .061 added to the
end, essentially - check with Max Cook, he has used the new product recently
…On Wed, Sep 13, 2023 at 3:10 PM Adam Mahood ***@***.***> wrote:
MCD12Q1 is not a burned area product, it's a landcover product. If the
landcover product we're using is also out of date we should also change
that though
On Wed, Sep 13, 2023 at 3:05 PM Erick Verleye ***@***.***>
wrote:
> I updated the URLs in functions and main to
> https://e4ftl01.cr.usgs.gov/MOTA/MCD12Q1.061/. Dockerfile has base image
> updated and environment.yml has versions added to the packages. I pushed a
> new Docker image to earthlabcu/firedpy:issue_89 and tested it out on Samoa.
> If it checks out with @admahood <https://github.com/admahood> , I'll
> change the tag to latest.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #90
> Commit Summary
>
> - 1611f62
> <1611f62>
> Updating burned product URL everywhere to v 061
> - ad6a94c
> <ad6a94c>
> Updating dockerfile and environment.yml with versions
>
> File Changes
>
> (4 files <https://github.com/earthlab/firedpy/pull/90/files>)
>
> - *M* Dockerfile
> <https://github.com/earthlab/firedpy/pull/90/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557>
> (23)
> - *M* environment.yaml
> <https://github.com/earthlab/firedpy/pull/90/files#diff-0ff3348ae0de662ef053d7de057a7a92c091a09fc3d245c8da02bec028ca3d0b>
> (40)
> - *M* firedpy/__main__.py
> <https://github.com/earthlab/firedpy/pull/90/files#diff-9acf8676e1ae66d257d76d13ebf70f09be009902d249ba0e67670f3377e18b2e>
> (2)
> - *M* firedpy/functions.py
> <https://github.com/earthlab/firedpy/pull/90/files#diff-b67374bcf75d52e523b7a51d4a873285b6fc1478e3f6dd28b6f68af585ed3274>
> (4)
>
> Patch Links:
>
> - https://github.com/earthlab/firedpy/pull/90.patch
> - https://github.com/earthlab/firedpy/pull/90.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#90>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABXI3P7IEDPBIDXUVZP2OBTX2INZ3ANCNFSM6AAAAAA4XDAKEQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Ah OK, yeah the land cover has version 061 too. It looks like we are getting burned product from the UMD sftp server, not https://e4ftl01.cr.usgs.gov/MOTA/MCD64A1.061/ . Reading through their docs, we just need to update the 'C6' directory to be 'C61'. Just pushed with that update. Will reupload the docker now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the URLs in functions and main to https://e4ftl01.cr.usgs.gov/MOTA/MCD12Q1.061/. Dockerfile has base image updated and environment.yml has versions added to the packages. I pushed a new Docker image to earthlabcu/firedpy:issue_89 and tested it out on Samoa. If it checks out with @admahood , I'll change the tag to latest.