MakeLiteralForType shouldn't print <nil> for nil values (flyteorg#188)

* Add max concurrency to launch plan & execution spec (flyteorg#186) Signed-off-by: Haytham Abuelfutuh <[email protected]> * MakeLiteralForType shouldn't print <nil> for nil values Signed-off-by: Haytham Abuelfutuh <[email protected]> * bump Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Katrina Rogan <[email protected]>
eapolinario · Jun 17, 2021 · ec8a7fa · ec8a7fa
1 parent 4f4be4d
commit ec8a7fa
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/clients/go/coreutils/literals.go b/clients/go/coreutils/literals.go
@@ -489,6 +489,10 @@ func MakeLiteralForType(t *core.LiteralType, v interface{}) (*core.Literal, erro
 	case *core.LiteralType_Simple:
 		newT := t.Type.(*core.LiteralType_Simple)
 		strValue := fmt.Sprintf("%v", v)
+		if v == nil {
+			strValue = ""
+		}
+
 		if newT.Simple == core.SimpleType_STRUCT {
 			if _, isValueStringType := v.(string); !isValueStringType {
 				byteValue, err := json.Marshal(v)

diff --git a/clients/go/coreutils/literals_test.go b/clients/go/coreutils/literals_test.go
@@ -617,4 +617,14 @@ func TestMakeLiteralForType(t *testing.T) {
 		_, err := MakeLiteralForType(literalType, "m")
 		assert.Error(t, err)
 	})
+
+	t.Run("Nil string", func(t *testing.T) {
+		var literalType = &core.LiteralType{Type: &core.LiteralType_Simple{Simple: core.SimpleType_STRING}}
+		l, err := MakeLiteralForType(literalType, nil)
+		assert.NoError(t, err)
+		assert.Equal(t, "", l.GetScalar().GetPrimitive().GetStringValue())
+		l, err = MakeLiteralForType(literalType, "")
+		assert.NoError(t, err)
+		assert.Equal(t, "", l.GetScalar().GetPrimitive().GetStringValue())
+	})
 }