checking for NotFound grpc code instead of nil launchplan (flyteorg#441)

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario · Jun 6, 2022 · df5c201 · df5c201
1 parent ac293ed
commit df5c201
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/controller/nodes/subworkflow/launchplan/admin.go b/pkg/controller/nodes/subworkflow/launchplan/admin.go
@@ -153,11 +153,11 @@ func (a *adminLaunchPlanExecutor) GetLaunchPlan(ctx context.Context, launchPlanR
 
 	lp, err := a.adminClient.GetLaunchPlan(ctx, &getObjectRequest)
 	if err != nil {
+		if status.Code(err) == codes.NotFound {
+			return nil, errors.Wrapf(RemoteErrorNotFound, err, "No launch plan retrieved from Admin")
+		}
 		return nil, errors.Wrapf(RemoteErrorSystem, err, "Could not fetch launch plan definition from Admin")
 	}
-	if lp == nil {
-		return nil, errors.Wrapf(RemoteErrorNotFound, err, "No launch plan retrieved from Admin")
-	}
 
 	return lp, nil
 }