Skip to content

Commit

Permalink
woot woot (flyteorg#116)
Browse files Browse the repository at this point in the history
Co-authored-by: Konstantin Gizdarski <kgizdarski@lyft.com>
kosigz-lyft and kosigz authored Aug 19, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent eb9236e commit d094408
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/manager/impl/project_manager.go
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@ func (m *ProjectManager) ListProjects(ctx context.Context, request admin.Project
}

func (m *ProjectManager) UpdateProject(ctx context.Context, projectUpdate admin.Project) (*admin.ProjectUpdateResponse, error) {
var response *admin.ProjectUpdateResponse
var response admin.ProjectUpdateResponse
projectRepo := m.db.ProjectRepo()

// Fetch the existing project if exists. If not, return err and do not update.
@@ -78,7 +78,7 @@ func (m *ProjectManager) UpdateProject(ctx context.Context, projectUpdate admin.
return nil, err
}

return response, nil
return &response, nil
}

func NewProjectManager(db repositories.RepositoryInterface, config runtimeInterfaces.Configuration) interfaces.ProjectInterface {
6 changes: 6 additions & 0 deletions tests/project.go
Original file line number Diff line number Diff line change
@@ -80,6 +80,9 @@ func TestUpdateProjectDescription(t *testing.T) {
Description: "a-new-description",
})

// Assert that update went through without an error.
assert.Nil(t, err)

// Fetch updated projects.
projectsUpdated, err := client.ListProjects(ctx, &admin.ProjectListRequest{})
assert.Nil(t, err)
@@ -134,6 +137,9 @@ func TestUpdateProjectLabels(t *testing.T) {
},
})

// Assert that update went through without an error.
assert.Nil(t, err)

// Fetch updated projects.
projectsUpdated, err := client.ListProjects(ctx, &admin.ProjectListRequest{})
assert.Nil(t, err)

0 comments on commit d094408

Please sign in to comment.