Bind pflags to default variable fields && Remove short flags as they'…

…re not supported by pflags (flyteorg#124) * * Bind pflags to default variable fields * Remove short flags as they're not supported by pflags Signed-off-by: Sean Lin <[email protected]> * Add --default-var to config.go Signed-off-by: Sean Lin <[email protected]> * * merge change from master branch * remove config_test as the generated test conflicts with it Signed-off-by: Sean Lin <[email protected]> * Add config_test.go to commit Signed-off-by: Sean Lin <[email protected]> * Update command help doc Signed-off-by: Sean Lin <[email protected]> * Use camelCase for flags Signed-off-by: Sean Lin <[email protected]> * Remove short flags from docs Signed-off-by: Sean Lin <[email protected]> * Update docs Signed-off-by: Sean Lin <[email protected]>
eapolinario · Jul 9, 2021 · c2a9b5f · c2a9b5f
1 parent 4769904
commit c2a9b5f
Show file tree

Hide file tree

Showing 96 changed files with 504 additions and 502 deletions.
diff --git a/cmd/config/config.go b/cmd/config/config.go
@@ -9,7 +9,7 @@ import (
 	"github.com/flyteorg/flytectl/pkg/printer"
 )
 
-//go:generate pflags Config
+//go:generate pflags Config --bind-default-var
 
 var (
 	defaultConfig = &Config{}

diff --git a/cmd/config/config_flags.go b/cmd/config/config_flags.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/attrdeleteconfig_flags.go b/cmd/config/subcommand/clusterresourceattribute/attrdeleteconfig_flags.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/attrdeleteconfig_flags_test.go b/cmd/config/subcommand/clusterresourceattribute/attrdeleteconfig_flags_test.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/attrfetchconfig_flags.go b/cmd/config/subcommand/clusterresourceattribute/attrfetchconfig_flags.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/attrfetchconfig_flags_test.go b/cmd/config/subcommand/clusterresourceattribute/attrfetchconfig_flags_test.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/attrupdateconfig_flags.go b/cmd/config/subcommand/clusterresourceattribute/attrupdateconfig_flags.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/attrupdateconfig_flags_test.go b/cmd/config/subcommand/clusterresourceattribute/attrupdateconfig_flags_test.go
diff --git a/cmd/config/subcommand/clusterresourceattribute/delete_config.go b/cmd/config/subcommand/clusterresourceattribute/delete_config.go
@@ -1,6 +1,6 @@
 package clusterresourceattribute
 
-//go:generate pflags AttrDeleteConfig --default-var DefaultDelConfig
+//go:generate pflags AttrDeleteConfig --default-var DefaultDelConfig --bind-default-var
 
 // AttrDeleteConfig Matchable resource attributes configuration passed from command line
 type AttrDeleteConfig struct {

diff --git a/cmd/config/subcommand/clusterresourceattribute/fetch_config.go b/cmd/config/subcommand/clusterresourceattribute/fetch_config.go
@@ -1,6 +1,6 @@
 package clusterresourceattribute
 
-//go:generate pflags AttrFetchConfig --default-var DefaultFetchConfig
+//go:generate pflags AttrFetchConfig --default-var DefaultFetchConfig --bind-default-var
 
 type AttrFetchConfig struct {
 	AttrFile string `json:"attrFile" pflag:",attribute file name to be used for generating attribute for the resource type."`

diff --git a/cmd/config/subcommand/clusterresourceattribute/update_config.go b/cmd/config/subcommand/clusterresourceattribute/update_config.go
@@ -1,6 +1,6 @@
 package clusterresourceattribute
 
-//go:generate pflags AttrUpdateConfig --default-var DefaultUpdateConfig
+//go:generate pflags AttrUpdateConfig --default-var DefaultUpdateConfig --bind-default-var
 
 // AttrUpdateConfig Matchable resource attributes configuration passed from command line
 type AttrUpdateConfig struct {

diff --git a/cmd/config/subcommand/execution/config_flags.go b/cmd/config/subcommand/execution/config_flags.go
diff --git a/cmd/config/subcommand/execution/config_flags_test.go b/cmd/config/subcommand/execution/config_flags_test.go
diff --git a/cmd/config/subcommand/executionclusterlabel/attrdeleteconfig_flags.go b/cmd/config/subcommand/executionclusterlabel/attrdeleteconfig_flags.go
diff --git a/cmd/config/subcommand/executionclusterlabel/attrdeleteconfig_flags_test.go b/cmd/config/subcommand/executionclusterlabel/attrdeleteconfig_flags_test.go
diff --git a/cmd/config/subcommand/executionclusterlabel/attrfetchconfig_flags.go b/cmd/config/subcommand/executionclusterlabel/attrfetchconfig_flags.go
diff --git a/cmd/config/subcommand/executionclusterlabel/attrfetchconfig_flags_test.go b/cmd/config/subcommand/executionclusterlabel/attrfetchconfig_flags_test.go
diff --git a/cmd/config/subcommand/executionclusterlabel/attrupdateconfig_flags.go b/cmd/config/subcommand/executionclusterlabel/attrupdateconfig_flags.go
diff --git a/cmd/config/subcommand/executionclusterlabel/attrupdateconfig_flags_test.go b/cmd/config/subcommand/executionclusterlabel/attrupdateconfig_flags_test.go
diff --git a/cmd/config/subcommand/executionclusterlabel/delete_config.go b/cmd/config/subcommand/executionclusterlabel/delete_config.go
@@ -1,6 +1,6 @@
 package executionclusterlabel
 
-//go:generate pflags AttrDeleteConfig --default-var DefaultDelConfig
+//go:generate pflags AttrDeleteConfig --default-var DefaultDelConfig --bind-default-var
 
 // AttrDeleteConfig Matchable resource attributes configuration passed from command line
 type AttrDeleteConfig struct {

diff --git a/cmd/config/subcommand/executionclusterlabel/fetch_config.go b/cmd/config/subcommand/executionclusterlabel/fetch_config.go
@@ -1,6 +1,6 @@
 package executionclusterlabel
 
-//go:generate pflags AttrFetchConfig --default-var DefaultFetchConfig
+//go:generate pflags AttrFetchConfig --default-var DefaultFetchConfig --bind-default-var
 
 type AttrFetchConfig struct {
 	AttrFile string `json:"attrFile" pflag:",attribute file name to be used for generating attribute for the resource type."`