[Compiler] When multiple nodes call the same workflow, the compiler a…

…ttempts to validate an already compiled WF (flyteorg#210)
eapolinario · Dec 3, 2020 · be093b9 · be093b9
1 parent b787e89
commit be093b9
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/pkg/compiler/validators/node.go b/pkg/compiler/validators/node.go
@@ -120,6 +120,10 @@ func ValidateNode(w c.WorkflowBuilder, n c.NodeBuilder, validateConditionTypes b
 		errs.Collect(errors.NewValueRequiredErr("<node>", "Id"))
 	}
 
+	if n.GetId() == c.StartNodeID || n.GetId() == c.EndNodeID {
+		return true
+	}
+
 	if _, ifaceOk := ValidateUnderlyingInterface(w, n, errs.NewScope()); ifaceOk {
 		// Validate node output aliases
 		validateEffectiveOutputParameters(n, errs.NewScope())

diff --git a/pkg/compiler/validators/node_test.go b/pkg/compiler/validators/node_test.go
@@ -3,6 +3,8 @@ package validators
 import (
 	"testing"
 
+	"github.com/lyft/flytepropeller/pkg/compiler/common"
+
 	"github.com/lyft/flyteidl/gen/pb-go/flyteidl/core"
 
 	"github.com/lyft/flytepropeller/pkg/compiler/common/mocks"
@@ -33,3 +35,15 @@ func TestValidateBranchNode(t *testing.T) {
 		}
 	})
 }
+
+func TestValidateNode(t *testing.T) {
+	n := &mocks.NodeBuilder{}
+	n.OnGetId().Return(common.StartNodeID)
+
+	wf := &mocks.WorkflowBuilder{}
+	errs := errors.NewCompileErrors()
+	ValidateNode(wf, n, true, errs)
+	if errs.HasErrors() {
+		assert.NoError(t, errs)
+	}
+}