forked from flyteorg/flyte
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[K8s Array] Fix ResourceQuota usage + logs for partially running jobs (…
…flyteorg#175) * Fix ResourceQuota usage + logs for partailly running jobs Signed-off-by: Anmol Khurana <[email protected]> * re-work log Signed-off-by: Anmol Khurana <[email protected]> * Use cache to lookup pod Signed-off-by: Anmol Khurana <[email protected]> * Update go/tasks/plugins/array/k8s/task.go Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Anmol Khurana <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
- Loading branch information
1 parent
ff648a8
commit b77864e
Showing
7 changed files
with
270 additions
and
38 deletions.
There are no files selected for viewing
173 changes: 173 additions & 0 deletions
173
flyteplugins/go/tasks/pluginmachinery/core/mocks/fake_k8s_cache.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| package mocks | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "reflect" | ||
| "sync" | ||
|
|
||
| "sigs.k8s.io/controller-runtime/pkg/cache" | ||
|
|
||
| "k8s.io/apimachinery/pkg/api/meta" | ||
|
|
||
| "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| type FakeKubeCache struct { | ||
| syncObj sync.RWMutex | ||
| Cache map[string]runtime.Object | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) GetInformer(ctx context.Context, obj client.Object) (cache.Informer, error) { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) GetInformerForKind(ctx context.Context, gvk schema.GroupVersionKind) (cache.Informer, error) { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) Start(ctx context.Context) error { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) WaitForCacheSync(ctx context.Context) bool { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) IndexField(ctx context.Context, obj client.Object, field string, extractValue client.IndexerFunc) error { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) Get(ctx context.Context, key client.ObjectKey, out client.Object) error { | ||
| m.syncObj.RLock() | ||
| defer m.syncObj.RUnlock() | ||
|
|
||
| item, found := m.Cache[formatKey(key, out.GetObjectKind().GroupVersionKind())] | ||
| if found { | ||
| // deep copy to avoid mutating cache | ||
| item = item.(runtime.Object).DeepCopyObject() | ||
| _, isUnstructured := out.(*unstructured.Unstructured) | ||
| if isUnstructured { | ||
| // Copy the value of the item in the cache to the returned value | ||
| outVal := reflect.ValueOf(out) | ||
| objVal := reflect.ValueOf(item) | ||
| if !objVal.Type().AssignableTo(outVal.Type()) { | ||
| return fmt.Errorf("cache had type %s, but %s was asked for", objVal.Type(), outVal.Type()) | ||
| } | ||
| reflect.Indirect(outVal).Set(reflect.Indirect(objVal)) | ||
| return nil | ||
| } | ||
|
|
||
| p, err := runtime.DefaultUnstructuredConverter.ToUnstructured(item) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return runtime.DefaultUnstructuredConverter.FromUnstructured(p, out) | ||
| } | ||
|
|
||
| return errors.NewNotFound(schema.GroupResource{}, key.Name) | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) List(ctx context.Context, list client.ObjectList, opts ...client.ListOption) error { | ||
| m.syncObj.RLock() | ||
| defer m.syncObj.RUnlock() | ||
|
|
||
| objs := make([]runtime.Object, 0, len(m.Cache)) | ||
|
|
||
| listOptions := &client.ListOptions{} | ||
| for _, opt := range opts { | ||
| opt.ApplyToList(listOptions) | ||
| } | ||
|
|
||
| for _, val := range m.Cache { | ||
| if listOptions.Raw != nil { | ||
| if val.GetObjectKind().GroupVersionKind().Kind != listOptions.Raw.Kind { | ||
| continue | ||
| } | ||
|
|
||
| if val.GetObjectKind().GroupVersionKind().GroupVersion().String() != listOptions.Raw.APIVersion { | ||
| continue | ||
| } | ||
| } | ||
|
|
||
| objs = append(objs, val.(runtime.Object).DeepCopyObject()) | ||
| } | ||
|
|
||
| return meta.SetList(list, objs) | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) Create(ctx context.Context, obj client.Object, opts ...client.CreateOption) (err error) { | ||
| m.syncObj.Lock() | ||
| defer m.syncObj.Unlock() | ||
|
|
||
| accessor, err := meta.Accessor(obj) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| key := formatKey(types.NamespacedName{ | ||
| Name: accessor.GetName(), | ||
| Namespace: accessor.GetNamespace(), | ||
| }, obj.GetObjectKind().GroupVersionKind()) | ||
|
|
||
| if _, exists := m.Cache[key]; !exists { | ||
| m.Cache[key] = obj | ||
| return nil | ||
| } | ||
|
|
||
| return errors.NewAlreadyExists(schema.GroupResource{}, accessor.GetName()) | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) Delete(ctx context.Context, obj client.Object, opts ...client.DeleteOption) error { | ||
| m.syncObj.Lock() | ||
| defer m.syncObj.Unlock() | ||
|
|
||
| accessor, err := meta.Accessor(obj) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| key := formatKey(types.NamespacedName{ | ||
| Name: accessor.GetName(), | ||
| Namespace: accessor.GetNamespace(), | ||
| }, obj.GetObjectKind().GroupVersionKind()) | ||
|
|
||
| delete(m.Cache, key) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (m *FakeKubeCache) Update(ctx context.Context, obj client.Object, opts ...client.UpdateOption) error { | ||
| m.syncObj.Lock() | ||
| defer m.syncObj.Unlock() | ||
|
|
||
| accessor, err := meta.Accessor(obj) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| key := formatKey(types.NamespacedName{ | ||
| Name: accessor.GetName(), | ||
| Namespace: accessor.GetNamespace(), | ||
| }, obj.GetObjectKind().GroupVersionKind()) | ||
|
|
||
| if _, exists := m.Cache[key]; exists { | ||
| m.Cache[key] = obj | ||
| return nil | ||
| } | ||
|
|
||
| return errors.NewNotFound(schema.GroupResource{}, accessor.GetName()) | ||
| } | ||
|
|
||
| func NewFakeKubeCache() *FakeKubeCache { | ||
| return &FakeKubeCache{ | ||
| syncObj: sync.RWMutex{}, | ||
| Cache: map[string]runtime.Object{}, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.